-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix magic string for runtime type #57141
fix magic string for runtime type #57141
Conversation
/assign @yujuhong |
/retest |
/cc @mindprince Since it seems that you can help to give this PR a mark to make it available to merge for 1.9 milestone. |
1.9 is almost ready to be released. I recommend this wait until code freeze on master lifts, and this can then make it in for 1.10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
SGTM. |
/approve no-issue This can wait until 1.9 is cut. |
@yujuhong As stated in the mailing list, v1.9 has been lifted and master branch is open for v1.10. Could we merge this? |
Yes, but there is nothing we need to do since the submit queue should pick this up automatcally |
a8fac3b
to
8189702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, feiskyer, yujuhong Associated issue requirement bypassed by: yujuhong The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 57148, 57123, 57091, 57141, 57131). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
This PR correct the magic string about container runtime to the constants.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
This PR correct the magic string about container runtime to the constants.
Release note: