Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix magic string for runtime type #57141

Conversation

andyxning
Copy link
Member

What this PR does / why we need it:
This PR correct the magic string about container runtime to the constants.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
This PR correct the magic string about container runtime to the constants.
Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 13, 2017
@andyxning
Copy link
Member Author

andyxning commented Dec 13, 2017

/assign @yujuhong
/cc @derekmahar @dims since both of you modified this file recently.

@andyxning
Copy link
Member Author

/retest

@andyxning
Copy link
Member Author

/cc @mindprince Since it seems that you can help to give this PR a mark to make it available to merge for 1.9 milestone.

@ncdc
Copy link
Member

ncdc commented Dec 13, 2017

1.9 is almost ready to be released. I recommend this wait until code freeze on master lifts, and this can then make it in for 1.10.

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2017
@andyxning
Copy link
Member Author

1.9 is almost ready to be released. I recommend this wait until code freeze on master lifts, and this can then make it in for 1.10.

SGTM.

@yujuhong
Copy link
Contributor

/approve no-issue

This can wait until 1.9 is cut.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2017
@andyxning
Copy link
Member Author

@yujuhong As stated in the mailing list, v1.9 has been lifted and master branch is open for v1.10. Could we merge this?

@yujuhong
Copy link
Contributor

@yujuhong As stated in the mailing list, v1.9 has been lifted and master branch is open for v1.10. Could we merge this?

Yes, but there is nothing we need to do since the submit queue should pick this up automatcally

@andyxning andyxning force-pushed the fix_magic_string_for_runtime_type branch from a8fac3b to 8189702 Compare December 16, 2017 11:20
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2017
@andyxning
Copy link
Member Author

Ping @feiskyer @ncdc @yujuhong for lgtm and approve. :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2017
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, feiskyer, yujuhong

Associated issue requirement bypassed by: yujuhong

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57148, 57123, 57091, 57141, 57131). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f7ef915 into kubernetes:master Dec 17, 2017
@andyxning andyxning deleted the fix_magic_string_for_runtime_type branch December 17, 2017 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants