Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printFlexPersistentVolumeSource: fix format #57399

Merged

Conversation

php-coder
Copy link
Contributor

@php-coder php-coder commented Dec 19, 2017

What this PR does / why we need it:
This PR fixes invalid format.

Special notes for your reviewer:
Addresses #56460 (comment)
Fixes #57694

Release note:

NONE

PTAL @liggitt
CC @simo5

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2017
@php-coder
Copy link
Contributor Author

php-coder commented Dec 19, 2017

Connection error during awscli installation:

W1219 12:20:06.341] + pip install awscli
I1219 12:20:06.662] Downloading/unpacking awscli
I1219 12:20:07.137] Cleaning up...
I1219 12:20:07.292] Exception:
I1219 12:20:07.292] Traceback (most recent call last):
I1219 12:20:07.293]   File "/usr/lib/python2.7/dist-packages/pip/basecommand.py", line 122, in main
I1219 12:20:07.293]     status = self.run(options, args)
I1219 12:20:07.293]   File "/usr/lib/python2.7/dist-packages/pip/commands/install.py", line 290, in run
I1219 12:20:07.294]     requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
I1219 12:20:07.294]   File "/usr/lib/python2.7/dist-packages/pip/req.py", line 1198, in prepare_files
I1219 12:20:07.294]     do_download,
I1219 12:20:07.294]   File "/usr/lib/python2.7/dist-packages/pip/req.py", line 1376, in unpack_url
I1219 12:20:07.294]     self.session,
I1219 12:20:07.295]   File "/usr/lib/python2.7/dist-packages/pip/download.py", line 546, in unpack_http_url
I1219 12:20:07.295]     resp = session.get(target_url, stream=True)
I1219 12:20:07.295]   File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 469, in get
I1219 12:20:07.295]     return self.request('GET', url, **kwargs)
I1219 12:20:07.296]   File "/usr/lib/python2.7/dist-packages/pip/download.py", line 237, in request
I1219 12:20:07.296]     return super(PipSession, self).request(method, url, *args, **kwargs)
I1219 12:20:07.296]   File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 457, in request
I1219 12:20:07.296]     resp = self.send(prep, **send_kwargs)
I1219 12:20:07.297]   File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 569, in send
I1219 12:20:07.297]     r = adapter.send(request, **kwargs)
I1219 12:20:07.297]   File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 407, in send
I1219 12:20:07.297]     raise ConnectionError(err, request=request)
I1219 12:20:07.298] ConnectionError: ('Connection aborted.', error(104, 'Connection reset by peer'))

@php-coder
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@php-coder
Copy link
Contributor Author

/assign @janetkuo

@php-coder
Copy link
Contributor Author

/retest

@liggitt
Copy link
Member

liggitt commented Dec 19, 2017

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2017
@nikhita
Copy link
Member

nikhita commented Dec 26, 2017

@liggitt Would require /approve no-issue.

@zjj2wry
Copy link
Contributor

zjj2wry commented Dec 29, 2017

Fixes #57694

@php-coder
Copy link
Contributor Author

/retest

@liggitt
Copy link
Member

liggitt commented Jan 2, 2018

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, php-coder

Associated issue requirement bypassed by: liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

@php-coder: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-verify 1c41db6 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57399, 57751, 57475). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a0f8dd8 into kubernetes:master Jan 2, 2018
@php-coder php-coder deleted the fix_flex_pvs_describe branch January 2, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong format string in describers
9 participants