Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure disk: if the disk is not found, immediately detach it. This prevents azure keeps the bad request and stops issuing new request #58345

Merged
merged 1 commit into from
Jan 17, 2018
Merged

azure disk: if the disk is not found, immediately detach it. This prevents azure keeps the bad request and stops issuing new request #58345

merged 1 commit into from
Jan 17, 2018

Conversation

rootfs
Copy link
Contributor

@rootfs rootfs commented Jan 16, 2018 •
edited by feiskyer
Loading

What this PR does / why we need it:
Detach and clear bad disk URI

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #58344

Special notes for your reviewer:

Release note:

Detach and clear bad disk URI

@rootfs
azure disk: if the disk is not found, immediately detach it. This pre…
a8f7404 
…vents azure keeps the bad request and stops issuing new request

Signed-off-by: Huamin Chen <hchen@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2018
@rootfs
Copy link
Contributor Author

rootfs commented Jan 16, 2018

@andyzhangx

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2018
@rootfs
Copy link
Contributor Author

rootfs commented Jan 16, 2018

/sig azure
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/azure sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jan 16, 2018
@rootfs
Copy link
Contributor Author

rootfs commented Jan 16, 2018

/assign @brendandburns

@andyzhangx
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, rootfs

Associated issue: #58344

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2018
feiskyer
feiskyer approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 58319, 58345). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 23881a9 into kubernetes:master Jan 17, 2018
@andyzhangx
Copy link
Member

andyzhangx commented Jan 22, 2018 •
edited
Loading

@rootfs would you cherry pick this PR to 1.9, 1.8?
And I have checked managed disk, there is no such issue, this issue only remains to blob disk. The error Code="NotFound" would a little different than blob disk though.

E0122 03:11:45.231388       1 azure_controllerCommon.go:127] azureDisk - azure attach failed, err: compute.VirtualMachinesClient#CreateOrUpdate: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code="NotFound" Message="The entity was not found."

@andyzhangx
Copy link
Member

andyzhangx commented Jan 23, 2018 •
edited
Loading

/release-note

Detach and clear bad disk URI

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 23, 2018
This was referenced Jan 29, 2018
Merged
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 29, 2018
Merge pull request #58945 from andyzhangx/automated-cherry-pick-of-#5…
36750af 
…8345-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #58345: azure disk: if the disk is not found, immediately detach it.

Cherry pick of #58345 on release-1.7.

#58345: azure disk: if the disk is not found, immediately detach it.
k8s-github-robot pushed a commit that referenced this pull request Jan 30, 2018
Merge pull request #58944 from andyzhangx/automated-cherry-pick-of-#5…
9a146b2 
…8345-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #58345: azure disk: if the disk is not found, immediately detach it.

Cherry pick of #58345 on release-1.8.

#58345: azure disk: if the disk is not found, immediately detach it.
k8s-github-robot pushed a commit that referenced this pull request Jan 30, 2018
Merge pull request #58943 from andyzhangx/automated-cherry-pick-of-#5…
9ad232b 
…8345-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #58345: azure disk: if the disk is not found, immediately detach it.

Cherry pick of #58345 on release-1.9.

#58345: azure disk: if the disk is not found, immediately detach it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

Assignees

@colemickens colemickens

@feiskyer feiskyer

@andyzhangx andyzhangx

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid Azure disk stops other disk attaching
7 participants
@rootfs @andyzhangx @k8s-ci-robot @k8s-github-robot @feiskyer @colemickens @brendandburns