Adding basic example Flexvolume drivers and DaemonSet deployment example. #59149
Conversation
|
@verult: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. One of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
sig/storage
k8s-ci-robot
added
the
cncf-cla: yes
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
/retest |
| set -o pipefail | ||
|
|
||
| # TODO change to your desired driver. | ||
| VENDOR=k8s |
There was a problem hiding this comment.
Allow users to set this as environment variable and fail if they are not set? That way users can reuse this example.
| fi | ||
|
|
||
| cp "/$DRIVER" "/flexmnt/$driver_dir/.$DRIVER" | ||
| mv -f "/flexmnt/$driver_dir/.$DRIVER" "/flexmnt/$driver_dir/$DRIVER" |
There was a problem hiding this comment.
Use a tmp identifier so that users can realize they are tmp files Ex: .tmp_$DRIVER?
verult
force-pushed
the
flex-examples
branch
from
0ad52ef
to
5bbad58
Compare
|
Addressed comments |
|
/retest |
|
|
||
| # TODO change to your desired driver. | ||
| VENDOR=${VENDOR:-k8s} | ||
| DRIVER=${DRIVER:-dummy} |
There was a problem hiding this comment.
Hmm.. shall we fail if these variables are not set? How about we add a check and exit the container with a log? These variables have to be defined.
There was a problem hiding this comment.
I'd like to make it minimal effort for users to get a basic example running. Currently the user only has to copy the driver into the appropriate directory, then build and deploy.
I'll add a comment about that in the README
…DaemonSet deployment example
verult
force-pushed
the
flex-examples
branch
from
5bbad58
to
6dbfea1
Compare
|
/retest |
k8s-ci-robot
added
the
lgtm
|
/cc @brendandburns @eparis @thockin |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chakri-nelluri, thockin, verult The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 60470, 59149, 56075, 60280, 60504). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it: More example Flexvolume drivers as reference for driver authors, and an example driver deployment workflow.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #59148
/sig storage
/assign @chakri-nelluri @zmerlynn
/cc @wongma7
/release-note-none