Add others's status in hpa describe #59609
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
size/S
zhangxiaoyu-zidif
changed the title
|
/assign @liggitt |
|
Can you add a description of what this does? Why is it needed? |
|
@ericchiang |
| @@ -2875,6 +2875,24 @@ func describeHorizontalPodAutoscaler(hpa *autoscaling.HorizontalPodAutoscaler, e | |||
| w.Write(LEVEL_0, "failed to check Replication Controller\n") | |||
| } | |||
| } | |||
| if strings.ToLower(hpa.Spec.ScaleTargetRef.Kind) == "replicaSet" { | |||
There was a problem hiding this comment.
ToLower will never match "replicaSet"
We should not be adding hard coded scale targets to this function. If we want to use the generic scale client to fetch scale status, that would be better
| w.Write(LEVEL_0, "failed to check ReplicaSet\n") | ||
| } | ||
| } | ||
| if strings.ToLower(hpa.Spec.ScaleTargetRef.Kind) == "deployment" { |
There was a problem hiding this comment.
Same here. Don't add hardcoded scale targets. Replace the existing one with a call using the polymorphic scale client
There was a problem hiding this comment.
I find we can use subsource to show the current replicas and desired replicas, so I use it instead. =)
|
/test pull-kubernetes-e2e-gce |
k8s-ci-robot
added
release-note
|
@liggitt PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, zhangxiaoyu-zidif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kubernetes-e2e-gce |
|
Automatic merge from submit-queue (batch tested with PRs 61434, 61501, 59609, 61467, 61531). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Add other status in HPA describe
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: