-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set pod priority on kube-proxy manifest by default #60150
Set pod priority on kube-proxy manifest by default #60150
Conversation
/lgtm |
/test pull-kubernetes-verify |
/lgtm cancel We have not been able to move Priority and Preemption to Beta in 1.10. As a result, it won't be enabled by default in 1.10. I guess we should keep this PR open for the next cycle. |
Acked, thanks for the update. Let's punt this to the next milestone. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you must submit this now.
/lgtm
@bsalamat Thanks for the reminder. Should we cherrypick this in 1.11? |
/retest |
@MrHohn Yes, we should. |
@bsalamat Ack, thanks for confirming. |
/assign @bowei |
/lgtm /approve /status approved-for-milestone |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, bsalamat, MrHohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-bazel-build |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
…-upstream-release-1.11 Automatic merge from submit-queue. Automated cherry pick of #60150: Set pod priority on kube-proxy by default Cherry pick of #60150 on release-1.11. #60150: Set pod priority on kube-proxy by default ```release-note Set “priorityClassName: system-node-critical” on kube-proxy manifest by default. ```
/sig network |
What this PR does / why we need it:
Follow up of #59237, set pod priority on kube-proxy by default and remove the unneeded logic in startup script.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #NONE
Special notes for your reviewer:
/assign @bsalamat @bowei
cc @tanshanshan
Release note: