Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pod priority on kube-proxy manifest by default #60150

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Feb 21, 2018

What this PR does / why we need it:
Follow up of #59237, set pod priority on kube-proxy by default and remove the unneeded logic in startup script.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #NONE

Special notes for your reviewer:
/assign @bsalamat @bowei
cc @tanshanshan

Release note:

Set “priorityClassName: system-node-critical” on kube-proxy manifest by default.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 21, 2018
@bsalamat
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Mar 2, 2018

/test pull-kubernetes-verify

@bsalamat
Copy link
Member

bsalamat commented Mar 6, 2018

/lgtm cancel

We have not been able to move Priority and Preemption to Beta in 1.10. As a result, it won't be enabled by default in 1.10. I guess we should keep this PR open for the next cycle.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Mar 6, 2018

We have not been able to move Priority and Preemption to Beta in 1.10. As a result, it won't be enabled by default in 1.10. I guess we should keep this PR open for the next cycle.

Acked, thanks for the update. Let's punt this to the next milestone.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Jun 4, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2018
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you must submit this now.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Jun 27, 2018

@bsalamat Thanks for the reminder. Should we cherrypick this in 1.11?

@MrHohn
Copy link
Member Author

MrHohn commented Jun 27, 2018

/retest

@bsalamat
Copy link
Member

Should we cherrypick this in 1.11?

@MrHohn Yes, we should.

@MrHohn
Copy link
Member Author

MrHohn commented Jun 28, 2018

@bsalamat Ack, thanks for confirming.

@MrHohn
Copy link
Member Author

MrHohn commented Jun 28, 2018

/assign @bowei
for approval.

@bowei
Copy link
Member

bowei commented Jun 28, 2018

/lgtm

/approve

/status approved-for-milestone

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, bsalamat, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Jun 28, 2018

/test pull-kubernetes-bazel-build

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5a185e0 into kubernetes:master Jun 29, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 3, 2018
k8s-github-robot pushed a commit that referenced this pull request Jul 3, 2018
…-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #60150: Set pod priority on kube-proxy by default

Cherry pick of #60150 on release-1.11.

#60150: Set pod priority on kube-proxy by default

```release-note
Set “priorityClassName: system-node-critical” on kube-proxy manifest by default.
```
@marpaia
Copy link
Contributor

marpaia commented Jul 31, 2018

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants