Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing table converters for server side printing #60580

Merged
merged 2 commits into from Mar 1, 2018
Merged

Add missing table converters for server side printing #60580

merged 2 commits into from Mar 1, 2018

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 28, 2018 •
edited

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #60488

/assign @smarterclayton @juanvallejo
/kind bug

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 28, 2018
@soltysh soltysh added this to the v1.10 milestone Feb 28, 2018
@soltysh
Copy link
Contributor Author

soltysh commented Feb 28, 2018

Fixed the handlers that failed in the unit tests.

@smarterclayton
Copy link
Contributor

/approve
/approve-for-milestone

@smarterclayton smarterclayton added status/approved-for-milestone approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 28, 2018
@juanvallejo
Copy link
Contributor

lgtm
@soltysh thanks for writing these tests.
Although not particularly specific to this PR, we should also test service service-catalog resources with Table printers. I have made a note of this here.

@BenTheElder
Copy link
Member

/retest

@smarterclayton
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor Author

soltysh commented Mar 1, 2018

Although not particularly specific to this PR, we should also test service service-catalog resources with Table printers. I have made a note of this here.

@juanvallejo I've added ^ to #58536. We need to review that and mark what's done and what needs to be done in 1.11.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit b92807f into kubernetes:master Mar 1, 2018
@soltysh soltysh mentioned this pull request Mar 1, 2018
Closed
16 tasks
@ixdy ixdy mentioned this pull request Mar 1, 2018
Merged
xmudrii pushed a commit to xmudrii/kubernetes that referenced this pull request Mar 2, 2018
Merge pull request kubernetes#60669 from ixdy/bazel-test-visibility
79257fe 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add //test/e2e/... and //test/integration/... to //build/visible_to:COMMON_testing

**What this PR does / why we need it**: adds the common test packages `//test/e2e/...` and `//test/integration/...` to the `COMMON_testing` package group.

The immediate need for this is that kubernetes#60580 unintentionally broke the integration tests under bazel since it added a new dependency on `//pkg/kubectl/cmd/util` without adding an appropriate entry to `//build/visible_to:COMMON_testing`, and the integration tests aren't currently run under bazel for PRs. 

This PR fixes this breakage and proactively fixes future breakages by adding all packages under `//test/e2e` or `//test/integration` to `COMMON_testing`.

**Release note**:

```release-note
NONE
```

/assign @BenTheElder @monopole 
/kind bug
/priority important-soon
/sig testing
cc @kad
@soltysh soltysh deleted the table_converter branch March 8, 2018 15:38
@wojtek-t wojtek-t mentioned this pull request Apr 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo juanvallejo approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@dims dims Awaiting requested review from dims

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

@liggitt liggitt Awaiting requested review from liggitt

@mbohlool mbohlool Awaiting requested review from mbohlool

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

@thockin thockin Awaiting requested review from thockin

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@smarterclayton smarterclayton

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

Server side print returns generic information for deployments
6 participants
@soltysh @smarterclayton @juanvallejo @BenTheElder @k8s-ci-robot @k8s-github-robot