New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to etcd 3.1.12 to pick up critical fix #60998

Merged
merged 1 commit into from Mar 13, 2018

Conversation

@jpbetz
Contributor

jpbetz commented Mar 9, 2018

etcd 3.1.12 (as well as 3.2.17 and 3.3.2) was released yesterday to fix a bug critical to kubernetes:

Fix mvcc "unsynced" watcher restore operation.

  • "unsynced" watcher is watcher that needs to be in sync with events that have happened.
  • That is, "unsynced" watcher is the slow watcher that was requested on old revision.
  • "unsynced" watcher restore operation was not correctly populating its underlying watcher group.
  • Which possibly causes missing events from "unsynced" watchers.

This will be backported to 1.9 as well.

Release note:

Upgrade the default etcd server version to 3.1.12 to pick up critical etcd "mvcc "unsynced" watcher restore operation" fix.

cc @gyuho @wojtek-t @shyamjvs @timothysc @jdumars

REGISTRY?=k8s.gcr.io
# Images should be pushed to staging-k8s.gcr.io, which is aliased to gcr.io/google-containers.
# But currently that does not work, so we must instead push to gcr.io/google-containers directly.
PUSH_REGISTRY?=gcr.io/google-containers

This comment has been minimized.

@jpbetz

jpbetz Mar 9, 2018

Contributor

Pushing directly to staging-k8s.gcr.io did not work for me although from #57824 it looks like it is suppose to. Anyone know why?

cc @thockin

This comment has been minimized.

@shyamjvs

shyamjvs Mar 9, 2018

Member

Could you tell what the error is? Maybe it's related to the one I was seeing yesterday - #60891 (comment)

This comment has been minimized.

@jpbetz

jpbetz Mar 9, 2018

Contributor

I either get this (for layer pushes):

The push refers to a repository [staging-k8s.gcr.io/etcd]
21172253818c: Retrying in 5 seconds 
6689586d0bd6: Retrying in 4 seconds

Or, this (if layers already exist, but something needs to be tagged):

denied: Permission 'storage.objects.create' denied for bucket 'artifacts.google-containers.appspot.com'

Happens using both docker <cmd> and gcloud docker -- <cmd> works works if i instead do the same against gcr.io/google-containers. Permissions issue?

This comment has been minimized.

@shyamjvs

shyamjvs Mar 9, 2018

Member

Did you try gcloud auth login and authenticate yourself as k8s.production.user@?

This comment has been minimized.

@ixdy

ixdy Mar 9, 2018

Member

also, make sure you have gcloud 185.0.0 or newer and run gcloud beta auth configure-docker - this should allow docker push to work.

This comment has been minimized.

@jpbetz

jpbetz Mar 9, 2018

Contributor

That fixed the problem. Thanks @ixdy! I'll update this PR.

@@ -304,7 +304,7 @@ filename | sha256 hash
* Fixes a possible deadlock preventing quota from being recalculated ([#58107](https://github.com/kubernetes/kubernetes/pull/58107), [@ironcladlou](https://github.com/ironcladlou))
* Fixes a bug in Heapster deployment for google sink. ([#57902](https://github.com/kubernetes/kubernetes/pull/57902), [@kawych](https://github.com/kawych))
* GCE: Allows existing internal load balancers to continue using an outdated subnetwork ([#57861](https://github.com/kubernetes/kubernetes/pull/57861), [@nicksardo](https://github.com/nicksardo))
* Update etcd version to 3.1.11 ([#57811](https://github.com/kubernetes/kubernetes/pull/57811), [@xiangpengzhao](https://github.com/xiangpengzhao))
* Update etcd version to 3.1.12 ([#57811](https://github.com/kubernetes/kubernetes/pull/57811), [@xiangpengzhao](https://github.com/xiangpengzhao))

This comment has been minimized.

@cblecker

cblecker Mar 9, 2018

Member

This appears to be a mistake

This comment has been minimized.

@jpbetz

jpbetz Mar 9, 2018

Contributor

Good catch. Reverting.

@cblecker

This comment has been minimized.

Member

cblecker commented Mar 9, 2018

/approve

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 9, 2018

/approve
/retest

@jpbetz

This comment has been minimized.

Contributor

jpbetz commented Mar 10, 2018

/retest

@dims

This comment has been minimized.

Member

dims commented Mar 10, 2018

/test pull-kubernetes-e2e-gke

@jpbetz

This comment has been minimized.

Contributor

jpbetz commented Mar 11, 2018

@jpbetz

This comment has been minimized.

Contributor

jpbetz commented Mar 11, 2018

/retest

1 similar comment
@jpbetz

This comment has been minimized.

Contributor

jpbetz commented Mar 11, 2018

/retest

@cblecker

This comment has been minimized.

Member

cblecker commented Mar 12, 2018

@jpbetz This isn’t a flake: #61009

@cblecker

This comment has been minimized.

Member

cblecker commented Mar 12, 2018

/retest

@cblecker

/approve

@cblecker

This comment has been minimized.

Member

cblecker commented Mar 12, 2018

/assign @mikedanese @sttts
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 13, 2018

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 13, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@jpbetz @mikedanese @sttts @timothysc

Pull Request Labels
  • sig/api-machinery sig/gcp: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@sttts

This comment has been minimized.

Contributor

sttts commented Mar 13, 2018

/approve

@wojtek-t

This comment has been minimized.

Member

wojtek-t commented Mar 13, 2018

/approve no-issue

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy, jpbetz, sttts, timothysc, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 13, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 13, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit b651ed5 into kubernetes:master Mar 13, 2018

13 of 14 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-verify
Details
cla/linuxfoundation jpbetz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@shyamjvs shyamjvs referenced this pull request Mar 14, 2018

Closed

[test flakes] master-scalability suites #60589

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment