Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsNotFound should check ErrDefault404 and ErrUnexpectedResponseCode #61002

Merged
merged 1 commit into from
Mar 21, 2018
Merged

IsNotFound should check ErrDefault404 and ErrUnexpectedResponseCode #61002

merged 1 commit into from
Mar 21, 2018

Conversation

FengyunPan2
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 10, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2018
@FengyunPan2
Copy link
Contributor Author

/sig openstack

@k8s-ci-robot k8s-ci-robot added area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 10, 2018
@dims
Copy link
Member

dims commented Mar 10, 2018

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2018
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it.

/lgtm

@dims
Copy link
Member

dims commented Mar 10, 2018

/hold

( for comments from @anguslees )

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2018
Copy link
Member

@anguslees anguslees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anguslees, dims, FengyunPan2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Mar 14, 2018

/test pull-kubernetes-e2e-gce
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@dims
Copy link
Member

dims commented Mar 20, 2018

/assign @NickrenREN
/assign @anguslees

@dims
Copy link
Member

dims commented Mar 20, 2018

/cc @zetaab

@k8s-ci-robot
Copy link
Contributor

@dims: GitHub didn't allow me to request PR reviews from the following users: zetaab.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @zetaab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zetaab
Copy link
Member

zetaab commented Mar 20, 2018

this fixes also #61100 (openstack part)

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 60898, 60912, 60753, 61002, 60796). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit e3ac402 into kubernetes:master Mar 21, 2018
k8s-github-robot pushed a commit that referenced this pull request Mar 28, 2018
…61002-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #61002: IsNotFound should check ErrDefault404 and

Cherry pick of #61002 on release-1.9.

#61002: IsNotFound should check ErrDefault404 and
k8s-github-robot pushed a commit that referenced this pull request May 8, 2018
…-#61002-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #61002: IsNotFound should check ErrDefault404 and

Cherry pick of #61002 on release-1.10.

#61002: IsNotFound should check ErrDefault404 and
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants