ACTION REQUIRED for MountPropagation feature #61126
Conversation
k8s-ci-robot
added
release-note-action-required
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrewsykim Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -176,6 +176,7 @@ filename | sha256 hash | |||
| * action required: kube-proxy: feature gates are now specified as a map when provided via a JSON or YAML KubeProxyConfiguration, rather than as a string of key-value pairs. ([#57962](https://github.com/kubernetes/kubernetes/pull/57962), [@xiangpengzhao](https://github.com/xiangpengzhao)) | |||
| * Action Required: The boostrapped RBAC role and rolebinding for the `cloud-provider` service account is now deprecated. If you're currently using this service account, you must create and apply your own RBAC policy for new clusters. ([#59949](https://github.com/kubernetes/kubernetes/pull/59949), [@nicksardo](https://github.com/nicksardo)) | |||
| * ACTION REQUIRED: VolumeScheduling and LocalPersistentVolume features are beta and enabled by default. The PersistentVolume NodeAffinity alpha annotation is deprecated and will be removed in a future release. ([#59391](https://github.com/kubernetes/kubernetes/pull/59391), [@msau42](https://github.com/msau42)) | |||
| * ACTION REQUIRED: MountPropagation feature is now beta. As a result, all volume mounts in containers are now "rslave" on Linux by default. Any host paths that is not a `rslave` mount or a `rshared` mount will not work. On Linux, you can ensure that mounts are of type `rshared` by running `mount --make-rshared /path/to/mount`, otherwise set `MountPropagation=false` on the kubelet `--feature-gates` flag. ([#59252](https://github.com/kubernetes/kubernetes/pull/59252), [@jsafrane](https://github.com/jsafrane)) | |||
There was a problem hiding this comment.
I do not think this is accurate. This should read - "MountPropagation feature is now beta. As a result, all volume mounts in containers are now "rslave" on Linux by default. To make this default work in all Linux environments- you should have entire mount tree marked as shareable via mount --make-rshared / . All Linux distributions that use systemd already have root directory mounted as rshared and hence they need not do anything. In Linux environments without systemd we also recommend restarting docker daemon after marking root directory as rshared"
There was a problem hiding this comment.
Will update, thanks :). It seems this is a required feature for CSI, is that worth mentioning here too?
There was a problem hiding this comment.
We can leave it as it is. The CSI docs will cover this requirement in detail.
|
I'm not sure this is the right place for this update. CC'ing the release notes lead |
|
Good catch. This should not be merged. The details will go into the release notes draft. |
jdumars
added
the
do-not-merge
|
I left a referene to this PR in the release notes draft. |
Update CHANGELOG re: #61058.
Wasn't sure if these docs are autogenerated.