Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove rktnetes code #61432
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
Hold until the end of the freeze.
Is there anything in the Godep that we should clean up now that the entire kubelet/rkt package is gone?
I'll take a look at Godeps and see if there are dependencies that go away...
Should we do this in this same PR or in a follow up?
There are also some references to RKT_* variables under cluster/, but I'd like to deal with those in a follow up, in order to reduce risk.
Is there a procedure to maintain/update the Godeps?
I didn't find a script under hack/ that would update it or re-generate it... Do I need to save/restore? If you could point me at a documentation for the steps used to maintain that, that'd be great!
Ok so I looked into it, by running:
$ hack/run-in-gopath.sh hack/godep-restore.sh $ hack/run-in-gopath.sh hack/godep-save.sh
It removed packages
I don't know how related those are to this PR, from the looks of it, I think they aren't... So I think I'd prefer not to push a Godeps commit in this PR and do that separately. Let me know if you agree with that.
(Also, it turns out my
Ok, let me adjust my
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing