New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn server-print on by default in kubectl #61477

Merged
merged 1 commit into from Mar 28, 2018

Conversation

Projects
None yet
5 participants
@soltysh
Contributor

soltysh commented Mar 21, 2018

What this PR does / why we need it:
#55637 introduced -experimental-server-print that enabled users to opt-in to user server-side printing. This is a followup which enables this functionality by default, with the ability to fallback not to do it with --server-print=false.

/assign @smarterclayton @juanvallejo

Release note:

Enable server-side print in kubectl by default, with the ability to turn it off with --server-print=false
@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Mar 21, 2018

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Mar 26, 2018

@soltysh soltysh changed the title from WIP: Turn server-print on by default in kubectl to Turn server-print on by default in kubectl Mar 26, 2018

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Mar 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 28, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 28, 2018

Automatic merge from submit-queue (batch tested with PRs 61842, 61477, 61777). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 9c19c4e into kubernetes:master Mar 28, 2018

14 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@soltysh soltysh deleted the soltysh:server_print_default branch Mar 30, 2018

@juanvallejo juanvallejo referenced this pull request Mar 30, 2018

Open

Server-side printing continued #60712

5 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment