Ensure cloudprovider.InstanceNotFound is reported when the VM is not found on Azure #61531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
|
/sig azure |
k8s-ci-robot
added
sig/azure
kind/bug
karataliu
reviewed
Mar 22, 2018
| @@ -51,6 +52,9 @@ func (az *Cloud) GetVirtualMachineWithRetry(name types.NodeName) (compute.Virtua | |||
| var retryErr error | |||
| err := wait.ExponentialBackoff(az.requestBackoff(), func() (bool, error) { | |||
| machine, retryErr = az.getVirtualMachine(name) | |||
| if retryErr == cloudprovider.InstanceNotFound { | |||
| return false, cloudprovider.InstanceNotFound | |||
There was a problem hiding this comment.
should be true to prevent retrying?
|
/retest |
|
ping @karataliu @andyzhangx |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, karataliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 61434, 61501, 59609, 61467, 61531). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Mar 30, 2018
…31-upstream-release-1.9 Automatic merge from submit-queue. Automated cherry pick of #61531: Ensure cloudprovider.InstanceNotFound is reported when the VM is not found on Azure Cherry pick of #61531 on release-1.9. #61531: Ensure cloudprovider.InstanceNotFound is reported when the VM is not found on Azure
k8s-github-robot
pushed a commit
that referenced
this pull request
Mar 30, 2018
…31-upstream-release-1.10 Automatic merge from submit-queue. Automated cherry pick of #61531: Ensure cloudprovider.InstanceNotFound is reported when the VM is not found on Azure Cherry pick of #61531 on release-1.10. #61531: Ensure cloudprovider.InstanceNotFound is reported when the VM is not found on Azure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Azure ExponentialBackoff will still try to get VM information even when the VM has already been removed on Azure:
kubernetes/pkg/cloudprovider/providers/azure/azure_backoff.go
Lines 52 to 60 in 1365ce3
It should report
cloudprovider.InstanceNotFoundearly and avoid calling Azure APIs on such case.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #61465
Special notes for your reviewer:
Should be cherry-picked to v1.9
Release note: