Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rev the Azure SDK for networking. #61955

Merged
merged 3 commits into from
Apr 2, 2018
Merged

Rev the Azure SDK for networking. #61955

merged 3 commits into from
Apr 2, 2018

Conversation

brendandburns
Copy link
Contributor 

Rev the Azure SDK for networking to 2017-06-01

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 30, 2018
@brendandburns
Copy link
Contributor Author

@khenidak @feiskyer ptal.

Thanks!

khenidak
khenidak approved these changes Apr 2, 2018
View reviewed changes
Copy link
Contributor

@khenidak khenidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, khenidak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brendandburns
Copy link
Contributor Author

/retest

@brendandburns brendandburns added this to the v1.11 milestone Apr 2, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@brendandburns @khenidak

Action required: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.11 milestone.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.
sig owner: Must specify at least one label prefixed with sig/.

Help

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61096, 61955, 61542, 60597). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit cb6453e into kubernetes:master Apr 2, 2018
@feiskyer
Copy link
Member

feiskyer commented Apr 8, 2018

@brendanburns We should cherry-pick this vendor updates to v1.8 for fix Azure/AKS#199

@feiskyer
Copy link
Member

feiskyer commented Apr 8, 2018

Hmm, too many changes since v1.8. Let me choose an old version.

@ixdy ixdy mentioned this pull request Apr 12, 2018
Merged
cblecker pushed a commit to cblecker/kubernetes that referenced this pull request Apr 18, 2018
Merge pull request kubernetes#62499 from ixdy/update-kazel
af91dfc 
Automatic merge from submit-queue (batch tested with PRs 62436, 62499, 62664, 62685, 62660). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update kazel to include openapi tag detection fix

**What this PR does / why we need it**: includes the fix from kubernetes/repo-infra#67 for kubernetes/repo-infra#66, which was discovered in @thockin's PR https://github.com/kubernetes/kubernetes/pull/57600/files#r178665554.

**Special notes for your reviewer**: I'm not sure what's up with the large list of comment diffs in `Godeps.json`; it looks like the `git describe` strings were (unintentionally?) truncated in @brendanburns's PR kubernetes#61955.

**Release note**:

```release-note
NONE
```

/assign @brendanburns @thockin @mikedanese
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khenidak khenidak khenidak approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brendandburns @k8s-ci-robot @k8s-github-robot @feiskyer @khenidak