Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kazel openapi generator is matching itself #66

Closed
ixdy opened this issue Apr 2, 2018 · 0 comments
Closed

kazel openapi generator is matching itself #66

ixdy opened this issue Apr 2, 2018 · 0 comments

Comments

@ixdy
Copy link
Member

ixdy commented Apr 2, 2018 •
edited

As I just noticed in https://github.com/kubernetes/kubernetes/pull/57600/files#r178665554, the fuzzy logic in kazel includes itself when it's been vendored:

repo-infra/kazel/generator.go

Lines 78 to 80 in 06471ba

if bytes.Contains(b, []byte(openAPIGenTag)) {
includeMe = true
}

We could turn this into a regex, which might do a better job of detecting real build tags, but it'd probably be even better to use the go/build package to find tags.

cc @mikedanese @spxtr
@ixdy ixdy mentioned this issue Apr 11, 2018
Merged
@ixdy ixdy mentioned this issue Apr 12, 2018
Merged
cblecker pushed a commit to cblecker/kubernetes that referenced this issue Apr 18, 2018
Merge pull request kubernetes#62499 from ixdy/update-kazel
af91dfc 
Automatic merge from submit-queue (batch tested with PRs 62436, 62499, 62664, 62685, 62660). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update kazel to include openapi tag detection fix

**What this PR does / why we need it**: includes the fix from kubernetes/repo-infra#67 for kubernetes/repo-infra#66, which was discovered in @thockin's PR https://github.com/kubernetes/kubernetes/pull/57600/files#r178665554.

**Special notes for your reviewer**: I'm not sure what's up with the large list of comment diffs in `Godeps.json`; it looks like the `git describe` strings were (unintentionally?) truncated in @brendanburns's PR kubernetes#61955.

**Release note**:

```release-note
NONE
```

/assign @brendanburns @thockin @mikedanese
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ixdy