Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded TaintNodesByCondition to beta. #62111

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Upgraded TaintNodesByCondition to beta. #62111

merged 1 commit into from
Aug 9, 2018

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Apr 4, 2018

Signed-off-by: Da K. Ma klaus1982.cn@gmail.com

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
part of #62109

Release note:

Upgraded TaintNodesByCondition to beta.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2018
@k82cn k82cn mentioned this pull request Apr 4, 2018
Closed
15 tasks
@k82cn
Copy link
Member Author

k82cn commented Apr 4, 2018

/retest

@bsalamat
Copy link
Member

@k82cn I support moving this to Beta, but could you please make sure that "Node Controller" and "Node Problem Detector" add appropriate taints correctly when node has a problem, is shutting down, etc.?

@k82cn
Copy link
Member Author

k82cn commented Apr 10, 2018

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 10, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2018
@k82cn
Upgrade TaintNodesByCondition to beta.
9bf2a7f 
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
@Huang-Wei
Copy link
Member

^^ @k82cn some CI glitch above, need a /retest :)

@k82cn
Copy link
Member Author

k82cn commented Jul 24, 2018 •
edited

when node has a problem, is shutting down, etc.?

@bsalamat , they're handled for now: NotReady, Unreachable are tainted by this feature; ShutDown is tainted by #58635 . If node was deleted, we do not need to taint it :)

@k82cn
Copy link
Member Author

k82cn commented Jul 27, 2018

/retest

@k82cn
Copy link
Member Author

k82cn commented Jul 27, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2018
@k82cn
Copy link
Member Author

k82cn commented Jul 27, 2018

@bsalamat , PTAL :)

bsalamat
bsalamat approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2018
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2018
@Huang-Wei
Copy link
Member

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 67160, 67090, 67159, 66866, 62111). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 876e77e into kubernetes:master Aug 9, 2018
@k82cn k82cn deleted the k8s_62109_1 branch August 9, 2018 22:54
@aleksandra-malinowska aleksandra-malinowska mentioned this pull request Aug 17, 2018
Closed
@wojtek-t wojtek-t mentioned this pull request Aug 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

Assignees

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@k82cn @bsalamat @fejta-bot @Huang-Wei @k8s-github-robot @k8s-ci-robot