Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure expected load balancer is selected for Azure #62450

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Ensure expected load balancer is selected for Azure #62450

merged 1 commit into from
Apr 13, 2018

Conversation

feiskyer
Copy link
Member

What this PR does / why we need it:

Azure cloud provider is always selecting the last element of LB list. The reason is: getServiceLoadBalancer() refers the pointer of an local variable within for loop:

kubernetes/pkg/cloudprovider/providers/azure/azure_loadbalancer.go

Lines 202 to 206 in e7ed9b4

for _, existingLB := range existingLBs {
if strings.EqualFold(*existingLB.Name, defaultLBName) {
defaultLB = &existingLB
}
if isInternalLoadBalancer(&existingLB) != isInternal {

This is a common mistake as golang is actually reusing same variable within the loop. This PR fixes this issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62449

Special notes for your reviewer:

Release note:

Ensure expected load balancer is selected for Azure

/sig azure
/kind bug

@feiskyer
Ensure expected load balancer is selected for Azure
0f0e271 
Without this, the last element of LB list is always selected.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/azure kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 12, 2018
@feiskyer
Copy link
Member Author

/assign @andyzhangx

andyzhangx
andyzhangx reviewed Apr 13, 2018
View reviewed changes
pkg/cloudprovider/providers/azure/azure_loadbalancer.go
@@ -199,7 +199,8 @@ func (az *Cloud) getServiceLoadBalancer(service *v1.Service, clusterName string,

// check if the service already has a load balancer
if existingLBs != nil {
for _, existingLB := range existingLBs {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

existingLB will always change in every iteration, what's the orignial issue here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value changes, but not its address

andyzhangx
andyzhangx approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 13, 2018 •
edited
Loading

@feiskyer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 0f0e271 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 62146, 62450). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 4b26d70 into kubernetes:master Apr 13, 2018
@feiskyer feiskyer deleted the select-lb branch April 16, 2018 05:07
This was referenced Apr 16, 2018
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 17, 2018
Merge pull request #62609 from feiskyer/automated-cherry-pick-of-#624…
3893e67 
…50-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #62450: Ensure expected load balancer is selected for Azure

Cherry pick of #62450 on release-1.9.

#62450: Ensure expected load balancer is selected for Azure
k8s-github-robot pushed a commit that referenced this pull request Apr 18, 2018
Merge pull request #62608 from feiskyer/automated-cherry-pick-of-#624…
d79570e 
…50-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62450: Ensure expected load balancer is selected for Azure

Cherry pick of #62450 on release-1.10.

#62450: Ensure expected load balancer is selected for Azure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@yastij yastij yastij approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure cloud provider is always selecting the last element of LB list
5 participants
@feiskyer @k8s-ci-robot @k8s-github-robot @andyzhangx @yastij