Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PodStore to wait for being initialized #62465

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Fix PodStore to wait for being initialized #62465

merged 1 commit into from
Apr 12, 2018

Conversation

wojtek-t
Copy link
Member

Currently causing some e2e test failure (mostly restart nodes tests).

@k8s-ci-robot
Copy link
Contributor

@wojtek-t: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 12, 2018
shyamjvs
shyamjvs reviewed Apr 12, 2018
View reviewed changes
test/e2e/scalability/density.go Outdated
podStore := testutils.NewPodStore(c, metav1.NamespaceAll, label, fields.Everything())
podStore, err := testutils.NewPodStore(c, metav1.NamespaceAll, label, fields.Everything())
if err != nil {
framework.Logf("Couldn't initialize pod store: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to framework.ExpectNoError() here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

MaciekPytel
MaciekPytel reviewed Apr 12, 2018
View reviewed changes
test/e2e/framework/util.go
@@ -3068,7 +3071,7 @@ func DeleteResourceAndWaitForGC(c clientset.Interface, kind schema.GroupKind, ns
return err
}

ps, err := podStoreForSelector(c, ns, selector)
ps, err := testutils.NewPodStore(c, ns, selector, fields.Everything())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that actually equivalent to the previous version? In old code it's passing what looks like a specific selector and here you just pass fields.Everything?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please ignore, just saw the method below.

@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 12, 2018
@wojtek-t
Copy link
Member Author

/test pull-kubernetes-bazel-test

@shyamjvs
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2018
@wojtek-t
Copy link
Member Author

Once merged, we should cherrypick it to release branches to fix tests there.
@jpbetz @mbohlool - my recent fixes to tests exposed that problem

@MaciekPytel
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel, shyamjvs, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MaciekPytel MaciekPytel added this to the v1.10 milestone Apr 12, 2018
@MaciekPytel MaciekPytel added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Apr 12, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@MaciekPytel @shyamjvs @wojtek-t

Action required: This pull request requires label changes.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
sig owner: Must specify at least one label prefixed with sig/.

Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@MaciekPytel
Copy link
Contributor

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 12, 2018 •
edited
Loading

@wojtek-t: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 4cb9931 link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 62455, 62465, 62427, 62416, 62411). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a646803 into kubernetes:master Apr 12, 2018
This was referenced Apr 13, 2018
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 13, 2018
Merge pull request #62520 from wojtek-t/automated-cherry-pick-of-#624…
1adef51 
…65-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62465 upstream release 1.10 

Cherry pick of #62465 on release-1.10.
#62465 : Fix PodStore to wait for being initialized
k8s-github-robot pushed a commit that referenced this pull request Apr 13, 2018
Merge pull request #62528 from wojtek-t/automated-cherry-pick-of-#624…
71f69c0 
…65-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #62465 upstream release 1.9 

Cherry pick of #62465 on release-1.9.
#62465 : Fix PodStore to wait for being initialized
@wojtek-t wojtek-t mentioned this pull request Apr 16, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 19, 2018
Merge pull request #62651 from wojtek-t/automated-cherry-pick-of-#624…
c920050 
…65-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #62465 upstream release 1.8

Cherry pick of #62465 on release-1.9.
#62465 : Fix PodStore to wait for being initialized
@wojtek-t wojtek-t deleted the fix_pod_store branch May 17, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamjvs shyamjvs shyamjvs left review comments

@MaciekPytel MaciekPytel MaciekPytel left review comments

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@shyamjvs shyamjvs

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@wojtek-t @k8s-ci-robot @shyamjvs @MaciekPytel @k8s-github-robot