Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show help for deprecated Kubelet flags #62505

Merged
merged 2 commits into from
Apr 14, 2018
Merged

Show help for deprecated Kubelet flags #62505

merged 2 commits into from
Apr 14, 2018

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Apr 13, 2018

We recently deprecated a bunch of Kubelet flags, which caused them to disappear from --help output. This PR unhides these flags, so that the deprecation notice is clearly visible in --help.

Fixes: #62009

NONE

/cc @eparis

@mtaufen mtaufen added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/kubelet area/kubelet-api sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 13, 2018
@mtaufen mtaufen added this to the v1.11 milestone Apr 13, 2018
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 13, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2018
@mtaufen mtaufen mentioned this pull request Apr 13, 2018
Closed
eparis
eparis reviewed Apr 13, 2018
View reviewed changes
cmd/kubelet/app/options/options.go Outdated
@@ -390,6 +401,8 @@ func (f *KubeletFlags) AddFlags(fs *pflag.FlagSet) {
fs.StringVar(&f.BootstrapCheckpointPath, "bootstrap-checkpoint-path", f.BootstrapCheckpointPath, "<Warning: Alpha feature> Path to to the directory where the checkpoints are stored")

// DEPRECATED FLAGS
fs.StringVar(&f.BootstrapKubeconfig, "experimental-bootstrap-kubeconfig", f.BootstrapKubeconfig, "deprecated: use --bootstrap-kubeconfig")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to result in some funny help text, something like:

--experminetal-bootstrap-kubeconfig string  deprecated: use --bootstrap-kubeconfig (DEPRECATED: Use --bootstrap-kubeconfig) (default: $f.BootstrapKubeconfig)

Copy link
Contributor Author

@mtaufen mtaufen Apr 13, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks

@mtaufen mtaufen force-pushed the show-deprecated-help branch 2 times, most recently from 16d36d8 to 868213d Compare April 13, 2018 21:28
@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 13, 2018

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2018
@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 14, 2018

/status approved-for-milestone

@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 14, 2018

/assign @thockin

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@liggitt @mtaufen @thockin

Pull Request Labels
  • sig/node: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@thockin
Copy link
Member

thockin commented Apr 14, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtaufen, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit ee4d90a into kubernetes:master Apr 14, 2018
@hzxuzhonghu hzxuzhonghu mentioned this pull request Apr 16, 2018
Closed
@CaoShuFeng CaoShuFeng mentioned this pull request Apr 16, 2018
Closed
@liggitt liggitt mentioned this pull request May 3, 2018
Merged
@dims dims mentioned this pull request May 4, 2018
Merged
@liggitt liggitt mentioned this pull request May 30, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 1, 2018
Merge pull request #63448 from dims/automated-cherry-pick-of-#62505-u…
8959a0a 
…pstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62505: update godeps to use latest pflag

Cherry pick of #62505 on release-1.10.

#62505: update godeps to use latest pflag

```release-note
Show help for deprecated Kubelet flags
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eparis eparis eparis left review comments

Assignees

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/kubelet-api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mtaufen @k8s-github-robot @thockin @k8s-ci-robot @fejta-bot @eparis @liggitt