Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet: move QOSReserved from experimental to alpha feature gate #62509

Merged
merged 1 commit into from
Apr 19, 2018
Merged

kubelet: move QOSReserved from experimental to alpha feature gate #62509

merged 1 commit into from
Apr 19, 2018

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Apr 13, 2018 •
edited
Loading

Fixes #61665

Release note:

The --experimental-qos-reserve kubelet flags is replaced by the alpha level --qos-reserved flag or QOSReserved field in the kubeletconfig and requires the QOSReserved feature gate to be enabled.

/sig node
/assign @derekwaynecarr
/cc @mtaufen

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 13, 2018
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2018
@sjenning
Copy link
Contributor Author

/assign @derekwaynecarr

@sjenning
Copy link
Contributor Author

/cc @dashpole

derekwaynecarr
derekwaynecarr suggested changes Apr 14, 2018
View reviewed changes
Copy link
Member

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the minor nit on a typo.

pkg/features/kube_features.go Outdated
// owner: @sjenning
// alpha: v1.11
//
// Allows resource reservations as the QoS level preventing pods at lower QoS levels from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit “at the QoS level”

@derekwaynecarr
Copy link
Member

it would be good to add a node e2e in follow-on pr. I just tried to find one and could not find one.

@sjenning
Copy link
Contributor Author

@derekwaynecarr nit fixed

@tianshapjq tianshapjq mentioned this pull request Apr 17, 2018
Closed
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61962, 58972, 62509, 62606). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit e937441 into kubernetes:master Apr 19, 2018
mtaufen
mtaufen reviewed Apr 21, 2018
View reviewed changes
pkg/kubelet/apis/kubeletconfig/v1beta1/types.go
// Requires the QOSReserved feature gate to be enabled.
// Default: nil
// +optional
QOSReserved map[string]string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjenning This still needs `json:"qosReserved,omitempty"`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened follow on PR to fix this up #62925

@sjenning sjenning mentioned this pull request Apr 21, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 24, 2018
Merge pull request #62925 from sjenning/fixup-qosreserved-tag
61a8454 
Automatic merge from submit-queue (batch tested with PRs 63046, 62925, 63014). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubelet: fixup QOSReserved json tag

Fix up follow on to #62509

@mtaufen @derekwaynecarr
@kolyshkin kolyshkin mentioned this pull request May 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen mtaufen left review comments

@derekwaynecarr derekwaynecarr derekwaynecarr requested changes

@dashpole dashpole Awaiting requested review from dashpole

Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjenning @derekwaynecarr @k8s-ci-robot @k8s-github-robot @mtaufen