New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet: move QOSReserved from experimental to alpha feature gate #62509

Merged
merged 1 commit into from Apr 19, 2018

Conversation

@sjenning
Contributor

sjenning commented Apr 13, 2018

Fixes #61665

Release note:

The --experimental-qos-reserve kubelet flags is replaced by the alpha level --qos-reserved flag or QOSReserved field in the kubeletconfig and requires the QOSReserved feature gate to be enabled.

/sig node
/assign @derekwaynecarr
/cc @mtaufen

@sjenning

This comment has been minimized.

Contributor

sjenning commented Apr 13, 2018

/assign @derekwaynecarr

@sjenning

This comment has been minimized.

Contributor

sjenning commented Apr 13, 2018

/cc @dashpole

@k8s-ci-robot k8s-ci-robot requested a review from dashpole Apr 13, 2018

@derekwaynecarr

Just the minor nit on a typo.

// owner: @sjenning
// alpha: v1.11
//
// Allows resource reservations as the QoS level preventing pods at lower QoS levels from

This comment has been minimized.

@derekwaynecarr

derekwaynecarr Apr 14, 2018

Member

Nit “at the QoS level”

@derekwaynecarr

This comment has been minimized.

Member

derekwaynecarr commented Apr 14, 2018

it would be good to add a node e2e in follow-on pr. I just tried to find one and could not find one.

@sjenning

This comment has been minimized.

Contributor

sjenning commented Apr 16, 2018

@derekwaynecarr nit fixed

@derekwaynecarr

This comment has been minimized.

Member

derekwaynecarr commented Apr 19, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 19, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 19, 2018

Automatic merge from submit-queue (batch tested with PRs 61962, 58972, 62509, 62606). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit e937441 into kubernetes:master Apr 19, 2018

15 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation sjenning authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
// Requires the QOSReserved feature gate to be enabled.
// Default: nil
// +optional
QOSReserved map[string]string

This comment has been minimized.

@mtaufen

mtaufen Apr 21, 2018

Contributor

@sjenning This still needs `json:"qosReserved,omitempty"`

This comment has been minimized.

@sjenning

sjenning Apr 21, 2018

Contributor

opened follow on PR to fix this up #62925

k8s-merge-robot added a commit that referenced this pull request Apr 24, 2018

Merge pull request #62925 from sjenning/fixup-qosreserved-tag
Automatic merge from submit-queue (batch tested with PRs 63046, 62925, 63014). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubelet: fixup QOSReserved json tag

Fix up follow on to #62509

@mtaufen @derekwaynecarr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment