Make pod status to Running if some are Running and some are Completed

[ceshihao]

What this PR does / why we need it:
Make pod status to Running if some are Running and some are Completed

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62588

Special notes for your reviewer:
Only Set Pod status to Completed when no other reason, no Running container and only Completed containers.

Set status to Running if some are Running and some are Completed

Release note:

Set pod status to "Running" if there is at least one container still reporting as "Running" status and others are "Completed".

[ceshihao]

/assign @smarterclayton

[hochuenw]

@ceshiha, it seems I can not ping this kind of pod (which some containers are Running and some are Completed) from another pod through service. Can this printer fix also fix that issue?

[ceshihao]

@hochuenw

No, it is different. I think it is another issue.

[mengqiy]

/ok-to-test
/cc @juanvallejo

[ceshihao]

/retest

[dixudx]

Better add a test for this change.

[ceshihao]

/retest

[ceshihao]

/test pull-kubernetes-e2e-kops-aws

[ceshihao]

/test pull-kubernetes-e2e-kops-aws

[juanvallejo]

What if the pod's status is Completed?
This line would make it so that Completed pods would appear with a Succeeded status, rather than Completed.

Why not simplify to this (or something similar)?

...
if !initializing {
    restarts = 0
    hasRunning := false
    for i := ... {
        ...
        // last "else if" in loop 
        } else if container.Ready && container.State.Running != nil {
            hasRunning = true
            readyContainers++
        }
    }

    // revert status back to "Running" if there is at least onr
    // container still reporting the "Running" status
    if reason == "Completed" && hasRunning {
        reason = "Running"
    }
}

[ceshihao]

Thank you.

Sounds great.
Change the pod status codes according to your comment.

[juanvallejo]

@soltysh fyi

[ceshihao]

/test pull-kubernetes-e2e-gce

[mengqiy]

We probably want a release note, since this is a behavior change to fix a bug.
The code LGTM

[juanvallejo]

lgtm pending a release note

[ceshihao]

Add a meaningful release note.

[dixudx]

/retest

[dixudx]

@ceshihao Would you please squash your commits. No need to have 4 commits on 2 files.

[ceshihao]

@dixudx
Squash to a single commit.

[dixudx]

/lgtm

[dixudx]

ping @kubernetes/sig-cli-maintainers for approval.

[smarterclayton]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ceshihao, dixudx, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/printers/OWNERS [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 62642, 62855, 62487, 62858, 62873). If you want to cherry-pick this change to another branch, please follow the instructions here.