-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kubelet flags. #62670
Fix kubelet flags. #62670
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtaufen, Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
@Random-Liu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
Automatic merge from submit-queue (batch tested with PRs 62568, 62220, 62743, 62751, 62753). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix extra-log flag for node e2e. Similar with #62670. Without this, test-infra can't collect extra logs, such as contianerd log. Signed-off-by: Lantao Liu <lantaol@google.com> **Release note**: ```release-note none ```
pflag now sets golang flag
Parsed
before parsing flags spf13/pflag@1ce0cc6. With that, all kubelet flags setting will be skipped.We initially added
flag.Parsed
check to work around a issue that flags are parsed twice, thus kubelet flags are appended twice.However, it doesn't seem to be the case now. I removed the
Parsed
check, and kubelet flags are only appended once.This PR removes the unnecessary
Parsed
check to fix the test. @mtaufen/cc @kubernetes/sig-node-pr-reviews
Signed-off-by: Lantao Liu lantaol@google.com
Release note: