Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra-log flag for node e2e. #62753

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Fix extra-log flag for node e2e. #62753

merged 1 commit into from
Apr 18, 2018

Conversation

Random-Liu
Copy link
Member

Similar with #62670.

Without this, test-infra can't collect extra logs, such as contianerd log.

Signed-off-by: Lantao Liu lantaol@google.com

Release note:

none

@Random-Liu
Fix extra-log flag for node e2e.
c86e85c 
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2018
@Random-Liu Random-Liu added sig/node Categorizes an issue or PR as relevant to SIG Node. area/node-e2e and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2018
@mtaufen
Copy link
Contributor

mtaufen commented Apr 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtaufen, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 62568, 62220, 62743, 62751, 62753). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit cce67ed into kubernetes:master Apr 18, 2018
@Random-Liu Random-Liu deleted the fix-extra-log branch June 1, 2018 20:06
@Random-Liu Random-Liu mentioned this pull request Jun 1, 2018
Merged
@Random-Liu Random-Liu added this to the v1.10 milestone Jun 1, 2018
k8s-github-robot pushed a commit that referenced this pull request Jun 2, 2018
Merge pull request #64629 from Random-Liu/automated-cherry-pick-of-#6…
5fa0f56 
…2753-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62753: Fix extra-log flag for node e2e.

Cherry pick of #62753 on release-1.10.

#62753: Fix extra-log flag for node e2e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc Awaiting requested review from ncdc

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@mtaufen mtaufen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/node-e2e cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Random-Liu @mtaufen @k8s-ci-robot @k8s-github-robot