Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring StorageObjectInUseProtection feature to GA #62870

Conversation

pospispa
Copy link
Contributor

What this PR does / why we need it:
It brings StorageObjectInUseProtection feature to GA.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes N/A

Special notes for your reviewer:
Related features: kubernetes/enhancements#498 and kubernetes/enhancements#499
Related PR: #61324

Release note:

StorageObjectInUseProtection feature is GA.

StorageObjectInUseProtection is Beta in K8s 1.10.

It's brought to GA in K8s 1.11.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 19, 2018
@pospispa
Copy link
Contributor Author

/sig storage
/kind feature
@tsmetana @jsafrane @NickrenREN @msau42 PTAL
/cc @saad-ali

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 19, 2018
@NickrenREN
Copy link
Contributor

/retest

@pospispa
Copy link
Contributor Author

@liggitt
I'd like to bring the StorageObjectInUse feature into GA. You adviced me here that for bringing the feature into GA I should just flip the feature status. So I'm proposing it in this PR. Please, would you review it?

@liggitt
Copy link
Member

liggitt commented Apr 23, 2018

lgtm, sig-storage has approval

@jsafrane
Copy link
Member

/lgtm
from sig-storage PV

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2018
@jsafrane
Copy link
Member

@childsb, @saad-ali, can you please approve?

@pospispa
Copy link
Contributor Author

/retest

@childsb
Copy link
Contributor

childsb commented Apr 26, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, jsafrane, pospispa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants