New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageObjectInUseProtection (was Persistent Volume Claim Protection) #498

Closed
pospispa opened this Issue Oct 26, 2017 · 24 comments

Comments

@pospispa

pospispa commented Oct 26, 2017

Feature Description

  • One-line feature description (can be used as a release note): Prevent deletion of Storage Object that is In active Use (was Prevent deletion of Persistent Volume Claims that are used by a pod in 1.9)
  • Primary contact (assignee): Pavel Pospisil (@pospispa)
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests
  • Design proposal link (community repo): kubernetes/community#1174
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs): @jsafrane
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.9
    • Beta release target (x.y): 1.10
    • Stable release target (x.y): 1.11
@pospispa

This comment has been minimized.

pospispa commented Oct 26, 2017

/assign

@pospispa

This comment has been minimized.

pospispa commented Oct 26, 2017

This feature aims to fix the bug: kubernetes/kubernetes#45143

@childsb childsb added this to the 1.9 milestone Oct 26, 2017

@saad-ali

This comment has been minimized.

Member

saad-ali commented Nov 17, 2017

@zacharysarah

This comment has been minimized.

Contributor

zacharysarah commented Nov 22, 2017

@pospispa 👋 Please indicate in the 1.9 feature tracking board
whether this feature needs documentation. If yes, please open a PR and add a link to the tracking spreadsheet. Thanks in advance!

@pospispa

This comment has been minimized.

pospispa commented Nov 23, 2017

@zacharysarah it seems I don't have write permission for the 1.9 feature tracking board.
Anyway, this feature needs documentation and a documentation PR is opened:
kubernetes/website#6415

@stewart-yu

This comment has been minimized.

stewart-yu commented Dec 5, 2017

Does have progress in this feature? I want to track about it

@pospispa

This comment has been minimized.

pospispa commented Dec 5, 2017

The alpha version of this feature is merged. PRs:

The alpha version doesn't include changes to scheduler that are not critical for the alpha version. Changes into scheduler are already approved (kubernetes/kubernetes#55957) and will be merged into K8s 1.10.

Documentatio PR is open and documentation is under review.

To sum it up, the alpha version of this feature should be released in K8s 1.9.

@saad-ali

This comment has been minimized.

Member

saad-ali commented Jan 23, 2018

This feature is planned to move to beta in 1.10

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this issue Feb 22, 2018

Merge pull request #59052 from pospispa/566-postpone-pvc-deletion-if-…
…used-in-a-pod-bring-to-beta

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Bring PVC Protection feature to Beta

**What this PR does / why we need it**:
Brings PVC Protection feature to Beta.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes # N/A

**Special notes for your reviewer**:
xref kubernetes/enhancements#498

**Release note**:

```release-note
PVC Protection alpha feature was renamed to Storage Protection. Storage Protection feature is beta.
```
@MikeSpreitzer

This comment has been minimized.

MikeSpreitzer commented Mar 28, 2018

Is kubernetes/community#1174 supposed to work when pods and PVCs are stored in different etcd clusters?

@liggitt

This comment has been minimized.

Member

liggitt commented Mar 28, 2018

Is kubernetes/community#1174 supposed to work when pods and PVCs are stored in different etcd clusters?

Yes, it works via finalizers on the API objects. It doesn't matter if those resources are backed by different etcd clusters.

Out of curiosity, are you aware of a setup that overrides etcd configuration to store PV and PVC objects in different etcd clusters?

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

@pospispa
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@msau42

This comment has been minimized.

Member

msau42 commented Apr 17, 2018

/assign @tsmetana

@pospispa

This comment has been minimized.

pospispa commented Apr 19, 2018

/milestone 1.11
/stage stable

@pospispa pospispa changed the title from Prevent deletion of Persistent Volume Claims that are used by a pod to StorageObjectInUseProtection (was Persistent Volume Claim Protection) Apr 19, 2018

@pospispa

This comment has been minimized.

pospispa commented Apr 19, 2018

@tsmetana @jsafrane please, would you update the labels to:
/milestone 1.11
/stage stable
as I don't have permissions for it.

@pospispa

This comment has been minimized.

pospispa commented Apr 19, 2018

@justaugustus I'd like to bring this feature to GA. I've created a PR: kubernetes/kubernetes#62870

Note: documentation changes are in PR kubernetes/website#7775 that should be re-opened after the source code is merged.

I've updated the feature description.

I don't have permission to update milestone and labels, but I hope @tsmetana or @jsafrane will update them.

@justaugustus justaugustus modified the milestones: v1.10, v1.11 Apr 20, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 20, 2018

Thanks for the update!

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this issue Apr 27, 2018

Merge pull request #62870 from pospispa/Bring-StorageObjectInUseProte…
…ction-feature-to-GA-2nd-attempt

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Bring StorageObjectInUseProtection feature to GA

**What this PR does / why we need it**:
It brings `StorageObjectInUseProtection` feature to GA.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes N/A

**Special notes for your reviewer**:
Related features: kubernetes/enhancements#498 and kubernetes/enhancements#499
Related PR: #61324

**Release note**:

```release-note
StorageObjectInUseProtection feature is GA.
```
@pospispa

This comment has been minimized.

pospispa commented Apr 27, 2018

@mistyhacks

This comment has been minimized.

mistyhacks commented May 21, 2018

Are this and #499 both covered by Docs PR kubernetes/website#8159? They are separate line items in the release spreadsheet for 1.11.

@pospispa

This comment has been minimized.

pospispa commented May 23, 2018

@mistyhacks yes, both are covered by kubernetes/website#8159
Originally they were planned as separate features for 1.9, but they were merged into StorageObjectInUseProtection feature in 1.10.

@AishSundar

This comment has been minimized.

AishSundar commented May 23, 2018

@pospispa I am the CI Signal lead for 1.11 and also work on Conformance testing program for K8s. I see this feature is going to Stable in 1.11.
I assume you already have e2e tests for it. I am following up to see if and which of those tests should we promote to the conformance suite in 1.11
As part of the process to increase conformance coverage, outlined by Conformance WG and Sig-Arch, we expect features going into stable/GA to have representation in Conformance suite. Your update on the same will help us evaluate this feature better.

@msau42

This comment has been minimized.

Member

msau42 commented Jun 15, 2018

General discussion for PVC/PV conformance testing here: kubernetes/kubernetes#65155

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Jul 23, 2018

@pospispa This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12. This still has the 1.11 milestone as well so we need to update it accordingly.

Can you please update the feature milestone tracking in the original post as well?
If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@msau42

This comment has been minimized.

Member

msau42 commented Jul 23, 2018

This feature went GA in 1.11. I think this can be closed?

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 23, 2018

Good catch, @msau42!
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment