Volume topology aware dynamic provisioning: work based on new API #63193

lichuqiang · 2018-04-26T10:56:02Z

What this PR does / why we need it:

The PR has been split to 3 parts:

Part1: #63232 for basic scheduler and PV controller plumbing
Part2: #63233 for API change

and the PR itself includes work based on the API change:

Dynamic provisioning allowed topologies scheduler work
Update provisioning interface to be aware of selected node and topology

Which issue(s) this PR fixes
Feature: kubernetes/enhancements#561
Design: kubernetes/community#2168

Special notes for your reviewer:
/sig storage
/sig scheduling
/assign @msau42 @jsafrane @saad-ali @bsalamat

@kubernetes/sig-storage-pr-reviews
@kubernetes/sig-scheduling-pr-reviews

Release note:

Volume topology aware dynamic provisioning

lichuqiang · 2018-04-27T02:07:11Z

pkg/controller/volume/persistentvolume/scheduler_binder.go

+	requested := claim.Spec.Resources.Requests[v1.ResourceStorage]
+	minVolumeSize := class.Status.Capacity.MinVolumeSize
+
+	if !isMinVolumeSizeSatisfied(requested, minVolumeSize) {


I misunderstood this part of MinVolumeSize in design, and thought we need to reject it if a user requested a volume under the minimum size.

msau42 · 2018-04-27T04:23:05Z

Can you split this PR into 3 PRs, since the API part is still under discussion:

API changes
Basic scheduler and PV controller plumbing
Scheduler work based on the new api

lichuqiang · 2018-04-27T05:50:27Z

@msau42 Sure thing, but the third pr would rely on the above two (in fact this existing PR should be the third one I think), I'll open another two PRs for api change and basic provisioning update

lichuqiang · 2018-06-05T05:37:09Z

/kind feature

lichuqiang · 2018-06-05T05:37:46Z

/priority important-soon

@msau42

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. API change for volume topology aware dynamic provisioning **What this PR does / why we need it**: Split PR kubernetes#63193 for better review part 2: API change Previous: kubernetes#63232 Next: kubernetes#63193 **Which issue(s) this PR fixes** Feature: kubernetes/enhancements#561 Design: kubernetes/community#2168 **Special notes for your reviewer**: /sig storage /sig scheduling /assign @msau42 @jsafrane @thockin **Release note**: ```release-note API change for volume topology aware dynamic provisioning ```

lichuqiang · 2018-06-05T08:41:41Z

After the former PR merged, I still can see the API related commits in this PR.
Not sure whether it matters, and I did another rebase to ensure it's in the right state.

@msau42

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. API change for volume topology aware dynamic provisioning **What this PR does / why we need it**: Split PR kubernetes/kubernetes#63193 for better review part 2: API change Previous: kubernetes/kubernetes#63232 Next: kubernetes/kubernetes#63193 **Which issue(s) this PR fixes** Feature: kubernetes/enhancements#561 Design: kubernetes/community#2168 **Special notes for your reviewer**: /sig storage /sig scheduling /assign @msau42 @jsafrane @thockin **Release note**: ```release-note API change for volume topology aware dynamic provisioning ``` Kubernetes-commit: 77d996b27883bed9d8b9015b608f9a0f0c60fd23

dims · 2018-06-05T13:37:30Z

/assign @lavalamp

saad-ali · 2018-06-05T17:23:28Z

/lgtm
/approve

lavalamp · 2018-06-05T18:14:40Z

/approve

For kube-controller-manager change (I didn't look at anything else).

k8s-ci-robot · 2018-06-05T18:14:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, lichuqiang, msau42, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/kube-controller-manager/OWNERS~~ [lavalamp]
~~pkg/controller/volume/persistentvolume/OWNERS~~ [lavalamp,msau42,saad-ali]
~~pkg/volume/OWNERS~~ [lavalamp,saad-ali]
~~test/OWNERS~~ [lavalamp,saad-ali]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dims · 2018-06-05T19:53:43Z

/test pull-kubernetes-e2e-gce

dims · 2018-06-05T20:40:44Z

/priority critical-urgent
/remove-priority important-soon

Bumping priority so the bot does not drop this when we get into code freeze.

k8s-github-robot · 2018-06-05T20:41:21Z

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bsalamat @jsafrane @lavalamp @lichuqiang @msau42 @saad-ali

Pull Request Labels

sig/scheduling sig/storage: Pull Request will be escalated to these SIGs if needed.
priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
kind/feature: New functionality.

Help

k8s-github-robot · 2018-06-05T21:31:33Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2018-06-05T22:31:57Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

k8s-ci-robot assigned bsalamat and jsafrane Apr 26, 2018

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 26, 2018

k8s-ci-robot assigned msau42 and saad-ali Apr 26, 2018

k8s-ci-robot requested review from brendandburns, childsb, davidz627, deads2k, eparis, erictune, hongchaodeng, jeffvance, jingxu97, jsafrane, karataliu, kerneltime, mbohlool, msau42 and nikhiljindal April 26, 2018 10:56

k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Apr 26, 2018

lichuqiang mentioned this pull request Apr 26, 2018

Local volume dynamic provisioning kubernetes-retired/external-storage#743

Closed

lichuqiang commented Apr 27, 2018

View reviewed changes

lichuqiang mentioned this pull request Apr 27, 2018

Volume topology aware dynamic provisioning: basic plumbing #63232

Merged

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 5, 2018

k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 5, 2018

k8s-github-robot removed the milestone/incomplete-labels label Jun 5, 2018

lichuqiang added 2 commits June 5, 2018 16:10

Dynamic provisioning allowed topologies scheduler work

dffbd75

Provision interface change

bccc8fe

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 5, 2018

k8s-github-robot removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jun 5, 2018

k8s-ci-robot assigned lavalamp Jun 5, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2018

k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 5, 2018

k8s-github-robot merged commit c615098 into kubernetes:master Jun 5, 2018

lichuqiang mentioned this pull request Jun 21, 2018

Should add volume topology-aware dynamic provisioning related integration case #65295

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Volume topology aware dynamic provisioning: work based on new API #63193

Volume topology aware dynamic provisioning: work based on new API #63193

lichuqiang commented Apr 26, 2018 •

edited

Loading

lichuqiang Apr 27, 2018

msau42 commented Apr 27, 2018 •

edited

Loading

lichuqiang commented Apr 27, 2018 •

edited

Loading

lichuqiang commented Jun 5, 2018

lichuqiang commented Jun 5, 2018

lichuqiang commented Jun 5, 2018

dims commented Jun 5, 2018

saad-ali commented Jun 5, 2018

lavalamp commented Jun 5, 2018

k8s-ci-robot commented Jun 5, 2018

dims commented Jun 5, 2018

dims commented Jun 5, 2018

k8s-github-robot commented Jun 5, 2018

k8s-github-robot commented Jun 5, 2018

k8s-github-robot commented Jun 5, 2018

Volume topology aware dynamic provisioning: work based on new API #63193

Volume topology aware dynamic provisioning: work based on new API #63193

Conversation

lichuqiang commented Apr 26, 2018 • edited Loading

lichuqiang Apr 27, 2018

Choose a reason for hiding this comment

msau42 commented Apr 27, 2018 • edited Loading

lichuqiang commented Apr 27, 2018 • edited Loading

lichuqiang commented Jun 5, 2018

lichuqiang commented Jun 5, 2018

lichuqiang commented Jun 5, 2018

dims commented Jun 5, 2018

saad-ali commented Jun 5, 2018

lavalamp commented Jun 5, 2018

k8s-ci-robot commented Jun 5, 2018

dims commented Jun 5, 2018

dims commented Jun 5, 2018

k8s-github-robot commented Jun 5, 2018

k8s-github-robot commented Jun 5, 2018

k8s-github-robot commented Jun 5, 2018

lichuqiang commented Apr 26, 2018 •

edited

Loading

msau42 commented Apr 27, 2018 •

edited

Loading

lichuqiang commented Apr 27, 2018 •

edited

Loading