New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go1.10.2 #63412

Merged
merged 1 commit into from May 5, 2018

Conversation

@praseodym
Contributor

praseodym commented May 3, 2018

What this PR does / why we need it:
Update to use go1.10.2 which includes some compiler and linker fixes.

Special notes for your reviewer:
Docker image golang:1.10.2 should be available soon.

Release note:

Update to use go1.10.2
@cblecker

/cc @ixdy
for image build/push

@@ -321,7 +321,7 @@ EOF
local go_version
IFS=" " read -ra go_version <<< "$(go version)"
local minimum_go_version
minimum_go_version=go1.10.1
minimum_go_version=go1.10.2

This comment has been minimized.

@cblecker

cblecker May 3, 2018

Member

This will likely fail because all the test-infra hasn't been upgraded yet. I don't think we need to enforce this as a minimum quiet yet either.

This comment has been minimized.

@praseodym

praseodym May 3, 2018

Contributor

Makes sense, removed.

This comment has been minimized.

@ixdy

ixdy May 3, 2018

Member

@BenTheElder can we bump test-infra?

This comment has been minimized.

@ixdy

ixdy May 3, 2018

Member

though in general I think the minimum go version here is more important for minor version bumps (e.g. 1.9 -> 1.10) than patch version bumps.

This comment has been minimized.

@BenTheElder

BenTheElder May 3, 2018

Member

yes, though not much picks up the go versions there, since mostly we either pick up the (in CI doubly so) containerized or bazel builds.

This comment has been minimized.

@BenTheElder

BenTheElder May 3, 2018

Member

discussed offline, we'll bump all the things

This comment has been minimized.

@praseodym

praseodym May 3, 2018

Contributor

I've re-added the bump here!

@k8s-ci-robot k8s-ci-robot requested a review from ixdy May 3, 2018

@cblecker cblecker self-assigned this May 3, 2018

sha256 = "4b2c61795ac2eefcb28f3eb8e1cb2d8fb3c2eafa0f6712473bc5f93728f38758",
urls = mirror("https://github.com/bazelbuild/rules_go/releases/download/0.10.2/rules_go-0.10.2.tar.gz"),
sha256 = "1868ff68d6079e31b2f09b828b58d62e57ca8e9636edff699247c9108518570b",
urls = mirror("https://github.com/bazelbuild/rules_go/releases/download/0.11.1/rules_go-0.11.1.tar.gz"),

This comment has been minimized.

@ixdy

ixdy May 3, 2018

Member

we should bump this instead to 0.10.4 (which still has the necessary go 1.10.2 support); 0.11.x is going to require BUILD updates, which will be more invasive.

This comment has been minimized.

@praseodym

praseodym May 3, 2018

Contributor

Changed to 0.10.4, let's do the 0.11.x update in another PR.

@BenTheElder

This comment has been minimized.

Member

BenTheElder commented May 3, 2018

/ok-to-test

@@ -15,7 +15,7 @@
# This file creates a standard build environment for building cross
# platform go binary for the architecture kubernetes cares about.
FROM golang:1.10.1
FROM golang:1.10.2

This comment has been minimized.

@BenTheElder

BenTheElder May 3, 2018

Member

this still doesn't appear to exist yet.

This comment has been minimized.

@BenTheElder

BenTheElder May 3, 2018

Member

ah, you have that in the PR body :-), hit this trying to prepare the related test-infra PR per @ixdy's request 🤷‍♂️

@praseodym

This comment has been minimized.

Contributor

praseodym commented May 4, 2018

/retest

@cblecker

This comment has been minimized.

Member

cblecker commented May 4, 2018

Tests aren’t going to pass until images are built and pushed.

@praseodym

This comment has been minimized.

Contributor

praseodym commented May 4, 2018

The golang:1.10.2 Docker image was just pushed 🙂 edit: but test infra isn’t, so that part still fails

@ixdy

This comment has been minimized.

Member

ixdy commented May 4, 2018

kube-cross image has been built; I'm working on getting this pushed to k8s.gcr.io now.

@ixdy

This comment has been minimized.

Member

ixdy commented May 4, 2018

/test pull-kubernetes-cross

@ixdy

ixdy approved these changes May 4, 2018

/approve

I think the test-infra images still need to be bumped. As soon as they're up in this lgtm.

@ixdy

This comment has been minimized.

Member

ixdy commented May 4, 2018

/assign @BenTheElder

@BenTheElder

This comment has been minimized.

Member

BenTheElder commented May 4, 2018

test-infra bump is ready in kubernetes/test-infra#7934

@BenTheElder

This comment has been minimized.

Member

BenTheElder commented May 5, 2018

test-infra bump went in
/retest

@dims

This comment has been minimized.

Member

dims commented May 5, 2018

/lgtm

(cross my fingers)

@k8s-ci-robot k8s-ci-robot added the lgtm label May 5, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented May 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ixdy, praseodym

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 5, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 5, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 678152b into kubernetes:master May 5, 2018

15 of 16 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation praseodym authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@praseodym praseodym deleted the praseodym:go1.10.2 branch May 5, 2018

@ingvagabund

This comment has been minimized.

Contributor

ingvagabund commented May 7, 2018

@ixdy, @BenTheElder, @dims can you CC me the next the minimal required Go version is bumped? So I can get ready and update the CI job for the node e2e tests over containerized kubelet in time. :) Thanks

@dims

This comment has been minimized.

Member

dims commented May 7, 2018

ack @ingvagabund will try to remember :)

@nikhita nikhita referenced this pull request Jul 30, 2018

Merged

Update to go 1.10.2 #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment