Update to go1.10.2 #63412
Update to go1.10.2 #63412
Conversation
k8s-ci-robot
added
release-note
| @@ -321,7 +321,7 @@ EOF | |||
| local go_version | |||
| IFS=" " read -ra go_version <<< "$(go version)" | |||
| local minimum_go_version | |||
| minimum_go_version=go1.10.1 | |||
| minimum_go_version=go1.10.2 | |||
There was a problem hiding this comment.
This will likely fail because all the test-infra hasn't been upgraded yet. I don't think we need to enforce this as a minimum quiet yet either.
There was a problem hiding this comment.
Makes sense, removed.
There was a problem hiding this comment.
@BenTheElder can we bump test-infra?
There was a problem hiding this comment.
though in general I think the minimum go version here is more important for minor version bumps (e.g. 1.9 -> 1.10) than patch version bumps.
There was a problem hiding this comment.
yes, though not much picks up the go versions there, since mostly we either pick up the (in CI doubly so) containerized or bazel builds.
There was a problem hiding this comment.
discussed offline, we'll bump all the things
There was a problem hiding this comment.
I've re-added the bump here!
build/root/WORKSPACE
Outdated
| sha256 = "4b2c61795ac2eefcb28f3eb8e1cb2d8fb3c2eafa0f6712473bc5f93728f38758", | ||
| urls = mirror("https://github.com/bazelbuild/rules_go/releases/download/0.10.2/rules_go-0.10.2.tar.gz"), | ||
| sha256 = "1868ff68d6079e31b2f09b828b58d62e57ca8e9636edff699247c9108518570b", | ||
| urls = mirror("https://github.com/bazelbuild/rules_go/releases/download/0.11.1/rules_go-0.11.1.tar.gz"), |
There was a problem hiding this comment.
we should bump this instead to 0.10.4 (which still has the necessary go 1.10.2 support); 0.11.x is going to require BUILD updates, which will be more invasive.
There was a problem hiding this comment.
Changed to 0.10.4, let's do the 0.11.x update in another PR.
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
| @@ -15,7 +15,7 @@ | |||
| # This file creates a standard build environment for building cross | |||
| # platform go binary for the architecture kubernetes cares about. | |||
|
|
|||
| FROM golang:1.10.1 | |||
| FROM golang:1.10.2 | |||
There was a problem hiding this comment.
this still doesn't appear to exist yet.
There was a problem hiding this comment.
ah, you have that in the PR body :-), hit this trying to prepare the related test-infra PR per @ixdy's request 🤷♂️
|
/retest |
|
Tests aren’t going to pass until images are built and pushed. |
|
The |
|
kube-cross image has been built; I'm working on getting this pushed to k8s.gcr.io now. |
|
/test pull-kubernetes-cross |
k8s-ci-robot
added
the
approved
|
/assign @BenTheElder |
|
test-infra bump is ready in kubernetes/test-infra#7934 |
|
test-infra bump went in |
|
/lgtm (cross my fingers) |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, ixdy, praseodym The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
|
@ixdy, @BenTheElder, @dims can you CC me the next the minimal required Go version is bumped? So I can get ready and update the CI job for the node e2e tests over containerized kubelet in time. :) Thanks |
|
ack @ingvagabund will try to remember :) |
What this PR does / why we need it:
Update to use go1.10.2 which includes some compiler and linker fixes.
Special notes for your reviewer:
Docker image
golang:1.10.2should be available soon.Release note: