Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump images for k/k master to go1.10.2 #7934

Merged
merged 4 commits into from
May 5, 2018

Conversation

BenTheElder
Copy link
Member

xref: kubernetes/kubernetes#63412

/area images
/hold

@BenTheElder BenTheElder requested a review from krzyzacy as a code owner May 3, 2018 22:42
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/images size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2018
@BenTheElder
Copy link
Member Author

PR currently contains the makefile / dockerfile changes, will update with the tag bumps after they're built and pushed

@BenTheElder
Copy link
Member Author

golang image isn't available still, will have to wait to get these out.

@praseodym
Copy link

Image is available now!

@BenTheElder
Copy link
Member Author

pushing these

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2018
@BenTheElder
Copy link
Member Author

gah, it seems a config change slipped in since my rebase.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2018
@BenTheElder
Copy link
Member Author

this should be good to go

@dims
Copy link
Member

dims commented May 4, 2018

@BenTheElder wanna remove hold or wait till monday?

@BenTheElder
Copy link
Member Author

/shrug
friday seems like the best time? /s

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label May 4, 2018
@BenTheElder
Copy link
Member Author

mostly this should probably be coordinated with the k/k PR

@cblecker
Copy link
Member

cblecker commented May 4, 2018

This needs to go in before the k/k PR. The k/k PR is waiting for this :)

@BenTheElder
Copy link
Member Author

BenTheElder commented May 5, 2018 via email

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2018
@BenTheElder
Copy link
Member Author

er this still needs an LGTM :-)

@cblecker
Copy link
Member

cblecker commented May 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2018
@dims
Copy link
Member

dims commented May 5, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d70474a into kubernetes:master May 5, 2018
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the config configmap from file prow/config.yaml

In response to this:

xref: kubernetes/kubernetes#63412

/area images
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the go1.10.2 branch June 5, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants