-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump images for k/k master to go1.10.2 #7934
Conversation
PR currently contains the makefile / dockerfile changes, will update with the tag bumps after they're built and pushed |
golang image isn't available still, will have to wait to get these out. |
Image is available now! |
pushing these |
gah, it seems a config change slipped in since my rebase. |
…r|experimental|releases) (using generate_tests and manual)
this should be good to go |
@BenTheElder wanna remove hold or wait till monday? |
/shrug |
mostly this should probably be coordinated with the k/k PR |
This needs to go in before the k/k PR. The k/k PR is waiting for this :) |
/hold cancel
👀
…On Fri, May 4, 2018, 4:59 PM Christoph Blecker ***@***.***> wrote:
This needs to go in before the k/k PR. The k/k PR is waiting for this :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7934 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA4Bq44ClCQxSLulUf7dwHQhIL-sISYFks5tvOtEgaJpZM4Tx4_l>
.
|
er this still needs an LGTM :-) |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, cblecker, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@BenTheElder: Updated the In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
xref: kubernetes/kubernetes#63412
/area images
/hold