New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move client based restmappers to client-go #63507

Merged
merged 3 commits into from May 8, 2018

Conversation

@deads2k
Contributor

deads2k commented May 7, 2018

Moves the client-based restmappers to client-go where everyone who needs them can have access.

the shortcuts which were moved server-side in at least 1.9 have been removed from being hardcoded in kubectl

@kubernetes/sig-cli-maintainers @kubernetes/sig-api-machinery-pr-reviews

@deads2k

This comment has been minimized.

Contributor

deads2k commented May 7, 2018

@soltysh @juanvallejo this is on the path to having a resource builder that only need a clientconfig function.

@timothysc timothysc removed their request for review May 7, 2018

@k8s-ci-robot k8s-ci-robot added size/XL and removed size/L labels May 8, 2018

@soltysh

soltysh approved these changes May 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 8, 2018

@deads2k

This comment has been minimized.

Contributor

deads2k commented May 8, 2018

/retest

1 similar comment
@deads2k

This comment has been minimized.

Contributor

deads2k commented May 8, 2018

/retest

@caesarxuchao

This comment has been minimized.

Member

caesarxuchao commented May 8, 2018

Moving the restmapper from client-go/discover to client-go/restmapper makes sense.
Moving the shortcut_restmapper from kubectl to client-go makes sense.

/approve

@deads2k

This comment has been minimized.

Contributor

deads2k commented May 8, 2018

/retest

@deads2k deads2k added the approved label May 8, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented May 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: caesarxuchao, deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 8, 2018

Automatic merge from submit-queue (batch tested with PRs 63291, 63490, 60445, 63507, 63524). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit c27335f into kubernetes:master May 8, 2018

16 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@deads2k deads2k deleted the deads2k:cli-50-tidyup branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment