move resource builder to generic options #63669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/L
k8s-ci-robot
added
approved
deads2k
force-pushed
the
cli-55-restmappersnip
branch
3 times, most recently
from
de7de6e
to
dfc0944
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deads2k
force-pushed
the
cli-55-restmappersnip
branch
from
dfc0944
to
dab2ac5
Compare
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
deads2k
added
the
lgtm
deads2k
force-pushed
the
cli-55-restmappersnip
branch
from
dab2ac5
to
16d6a6c
Compare
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
|
/retest |
deads2k
added
the
lgtm
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 63669, 63511, 63561, 63289). If you want to cherry-pick this change to another branch, please follow the instructions here. |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 1, 2018
This change is similar to kubernetes/kubernetes@fd044d15 (fix dynamic client name, 2018-05-09, kubernetes/kubernetes#63446, v1.11.0-beta.0) and it protects us from the eventual removal of k8s.io/kubernetes/pkg/kubectl/resource in kubernetes/kubernetes@16d6a6c5 (move resource builder to generic options, 2018-05-10, kubernetes/kubernetes#63669, v1.11.0-beta.0).
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 1, 2018
This change is similar to kubernetes/kubernetes@fd044d15 (fix dynamic client name, 2018-05-09, kubernetes/kubernetes#63446, v1.11.0-beta.0) and it protects us from the eventual removal of k8s.io/kubernetes/pkg/kubectl/resource in kubernetes/kubernetes@16d6a6c5 (move resource builder to generic options, 2018-05-10, kubernetes/kubernetes#63669, v1.11.0-beta.0).
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 2, 2018
This change is similar to kubernetes/kubernetes@fd044d15 (fix dynamic client name, 2018-05-09, kubernetes/kubernetes#63446, v1.11.0-beta.0) and it protects us from the eventual removal of k8s.io/kubernetes/pkg/kubectl/resource in kubernetes/kubernetes@16d6a6c5 (move resource builder to generic options, 2018-05-10, kubernetes/kubernetes#63669, v1.11.0-beta.0).
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 3, 2018
This change is similar to kubernetes/kubernetes@fd044d15 (fix dynamic client name, 2018-05-09, kubernetes/kubernetes#63446, v1.11.0-beta.0) and it protects us from the eventual removal of k8s.io/kubernetes/pkg/kubectl/resource in kubernetes/kubernetes@16d6a6c5 (move resource builder to generic options, 2018-05-10, kubernetes/kubernetes#63669, v1.11.0-beta.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull snips the last kube/kube links from the resource builder and moves it to the genericclioptions to be built out into flags from there.
@kubernetes/sig-cli-maintainers