Automated cherry pick of #62481: kubeadm preflight: check socket path if defined otherwise

[dixudx]

Cherry pick of #62481 on release-1.10.

#62481: kubeadm preflight: check socket path if defined otherwise

Fixes: kubernetes/kubeadm#814

[dixudx]

/assign timothysc luxas

@MikeSpreitzer @taharah FYI.

[luxas]

/lgtm
/approve

This is okay as a backport, but I think I want to rearrange some of the code at master.

[luxas]

I haven't made up my mind yet whether this is a good or a bad abstraction at this level for the specific use case, but I can let this pass as a backport for the moment.

[luxas]

kubeadmapiv1alpha1 in the future please

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, luxas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kubeadm/OWNERS [luxas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[luxas]

/hold
for @detiber or @timothysc to sign off

[timothysc]

I really don't think this seems backport worthy. We should only be backporting fixes that common bug scenarios, otherwise new changes will hit the next release cycle in ~1 month.

[MaciekPytel]

1.10 branch is now frozen for final testing before 1.10.3. Please don't remove hold on this until the release is cut (hopefully on Monday).

[dixudx]

/retest

[timothysc]

I'm still of the opinion that this doesn't meet the criteria for a backport, fwiw.

[MaciekPytel]

Removing cherrypick-approved based on comment from @timothysc. I'm ok to reapply it once consensus is reached on whether this should be cherrypicked or closed.

/hold cancel
Since the branch is no longer frozen

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[dixudx]

Seems the original author has changed his/her email address. The bot is complaining github user account and cncf-cla.

I changed the author mail to mine. But the credit should still gave to @taharah (You can try to sign cncf-cla again using your new email).

[dixudx]

@luxas @timothysc Needs your LGTM again. Thanks.

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Removed From Pull Request

@dixudx @luxas @timothysc @kubernetes/sig-cluster-lifecycle-misc

Important: This pull request was missing the status/approved-for-milestone label for more than 4 days.

Help

• Additional instructions
• Commands for setting labels

[MaciekPytel]

@dixudx @timothysc @luxas Can you make a decision if this needs to be cherry-picked and lgtm or close this PR?