Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #61069: Use pod UID as cache key instead of namespace/name #63995

Merged
merged 1 commit into from May 19, 2018
Merged

Automated cherry pick of #61069: Use pod UID as cache key instead of namespace/name #63995

merged 1 commit into from May 19, 2018

Conversation

resouer
Copy link
Contributor

@resouer resouer commented May 17, 2018

Cherry pick of #61069 on release-1.9.

#61069: Use pod UID as cache key instead of namespace/name

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 17, 2018
@resouer resouer requested review from bsalamat and removed request for timothysc and smarterclayton May 17, 2018 19:25
@resouer
Copy link
Contributor Author

resouer commented May 17, 2018 •
edited

Per discussion: #61069 (comment)

/assign @bsalamat for PR review and approve
/assign @smarterclayton for /pkg approve

bsalamat
bsalamat reviewed May 17, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @resouer! Looks good. Please make sure the tests pass.

@bsalamat bsalamat added this to the v1.9 milestone May 17, 2018
@bsalamat bsalamat added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. status/approved-for-milestone labels May 17, 2018
@k8s-github-robot k8s-github-robot added milestone/incomplete-labels and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 17, 2018
@bsalamat bsalamat added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 17, 2018
@bsalamat
Copy link
Member

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label May 17, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bsalamat @resouer @smarterclayton

Pull Request Labels
  • sig/scheduling: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@resouer resouer force-pushed the automated-cherry-pick-of-#61069-upstream-release-1.9 branch from 3930989 to 260ea27 Compare May 17, 2018 22:12
@resouer
Use pod UID as cache key instead of namespace/name
880e0cc 
UID uniquely identifies pods across lifecycles, while namespace/name
could be 2 different pods across lifecycles. This could result in
tricky scheduler bugs.

Fixes kubernetes#60966
@resouer resouer force-pushed the automated-cherry-pick-of-#61069-upstream-release-1.9 branch from 260ea27 to 880e0cc Compare May 18, 2018 21:11
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2018
@resouer
Copy link
Contributor Author

resouer commented May 19, 2018

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2018
bsalamat
bsalamat reviewed May 19, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, resouer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit c138b85 into kubernetes:release-1.9 May 19, 2018
@resouer resouer deleted the automated-cherry-pick-of-#61069-upstream-release-1.9 branch May 19, 2018 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat left review comments

Assignees

@smarterclayton smarterclayton

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@resouer @bsalamat @k8s-github-robot @k8s-ci-robot @smarterclayton