Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: update hcsshim to v0.6.11 #64272

Merged
merged 1 commit into from Jun 14, 2018
Merged

vendor: update hcsshim to v0.6.11 #64272

merged 1 commit into from Jun 14, 2018

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented May 24, 2018 •
edited

Ran all the godep scripts according to
https://github.com/kubernetes/community/blob/master/contributors/devel/godep.md,
seems like some other lines in Godeps.json got modified as well but they are all
the same sha only slightly longer...

Signed-off-by: Jess Frazelle acidburn@microsoft.com

cc @liggitt @cjcullen @tallclair @philips

Updated hcsshim dependency to v0.6.11

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 24, 2018
@jessfraz
Copy link
Contributor Author

@brendanburns or @smarterclayton can you approve this

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2018
@jessfraz
vendor: update hcsshim to v0.6.11
b6b4764 
Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2018
@jessfraz jessfraz added this to the v1.11 milestone Jun 14, 2018
@jessfraz jessfraz added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/windows Categorizes an issue or PR as relevant to SIG Windows. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 14, 2018
@jessfraz
Copy link
Contributor Author

/assign @cblecker

@khenidak
Copy link
Contributor

had a quick discussion with @jessfraz - The change is looking good, we just need to test it on windows (due to lack of windows e2e).

@jessfraz
Copy link
Contributor Author

verified it works :)

@cblecker
Copy link
Member

/test pull-kubernetes-cross

@cblecker
Copy link
Member

/approve
Dep bump looks fine. Existing import, no licence changes. It's used by pkg/proxy/winkernel/.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2018
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, cblecker, jessfraz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Jun 14, 2018

/status approved-for-milestone

per @brendanburns 's approval above

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@brendandburns @cblecker @jessfraz

Pull Request Labels
  • sig/windows: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@dims
Copy link
Member

dims commented Jun 14, 2018

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 72a0a79 into kubernetes:master Jun 14, 2018
@jessfraz jessfraz deleted the update-hcsshim branch June 14, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@cblecker cblecker

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jessfraz @khenidak @cblecker @brendandburns @k8s-ci-robot @dims @k8s-github-robot