Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump(github.com/evanphx/json-patch): 94e38aa1586e8a6c8a75770bddf5ff84c48a106b #64355

Merged
merged 1 commit into from
May 27, 2018
Merged

bump(github.com/evanphx/json-patch): 94e38aa1586e8a6c8a75770bddf5ff84c48a106b #64355

merged 1 commit into from
May 27, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 26, 2018 •
edited
Loading

update package github.com/evanphx/json-patch

fixes #64291

/cc wgliang cblecker

fixes a panic applying json patches containing out of bounds operations

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 26, 2018
@liggitt liggitt mentioned this pull request May 26, 2018
Closed
@wgliang
Copy link
Contributor

wgliang commented May 26, 2018

@liggitt
Are you sure you don't need to stay with the source? Because you deleted the cmd directory.

@liggitt
Copy link
Member Author

liggitt commented May 26, 2018 •
edited
Loading

Godep only copies in the packages referenced by kubernetes, and we do not reference the cmd package. This was the result of running godep-save, not of manually removing the cmd package.

@wgliang
Copy link
Contributor

wgliang commented May 26, 2018

@liggitt
ok, I will close #64353.

@wgliang
Copy link
Contributor

wgliang commented May 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2018
@liggitt
Copy link
Member Author

liggitt commented May 26, 2018

/assign @cblecker
/retest

@cblecker
Copy link
Member

/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, liggitt, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2018
@cblecker
Copy link
Member

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 27, 2018 •
edited
Loading

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 2d28e0d link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 0f71537 into kubernetes:master May 27, 2018
@wgliang wgliang mentioned this pull request May 29, 2018
Closed
@liggitt liggitt deleted the bump-jsonpatch branch May 29, 2018 13:16
@liggitt liggitt mentioned this pull request May 29, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 15, 2018
Merge pull request #64446 from liggitt/automated-cherry-pick-of-#6435…
320c55e 
…5-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #64355: bump(github.com/evanphx/json-patch):

Cherry pick of #64355 on release-1.10.

#64355: bump(github.com/evanphx/json-patch):
@alvaroaleman alvaroaleman mentioned this pull request May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@wgliang wgliang Awaiting requested review from wgliang

Assignees

@cblecker cblecker

@wgliang wgliang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APIServer crashes when a MutatingWebhook returns a faulty patch
6 participants
@liggitt @wgliang @cblecker @k8s-ci-robot @fejta-bot @k8s-github-robot