Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(github.com/evanphx/json-patch): 94e38aa1586e8a6c8a75770bddf5ff84c48a106b #64355

Merged
merged 1 commit into from May 27, 2018

Conversation

Projects
None yet
6 participants
@liggitt
Copy link
Member

liggitt commented May 26, 2018

update package github.com/evanphx/json-patch

fixes #64291

/cc wgliang cblecker

fixes a panic applying json patches containing out of bounds operations
@wgliang

This comment has been minimized.

Copy link
Member

wgliang commented May 26, 2018

@liggitt
Are you sure you don't need to stay with the source? Because you deleted the cmd directory.

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented May 26, 2018

Godep only copies in the packages referenced by kubernetes, and we do not reference the cmd package. This was the result of running godep-save, not of manually removing the cmd package.

@wgliang

This comment has been minimized.

Copy link
Member

wgliang commented May 26, 2018

@liggitt
ok, I will close #64353.

@wgliang

This comment has been minimized.

Copy link
Member

wgliang commented May 26, 2018

/lgtm

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented May 26, 2018

/assign @cblecker
/retest

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented May 26, 2018

/approve
/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, liggitt, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented May 27, 2018

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented May 27, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented May 27, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 27, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 27, 2018

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 2d28e0d link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 27, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 0f71537 into kubernetes:master May 27, 2018

14 of 18 checks passed

pull-kubernetes-e2e-gce-device-plugin-gpu Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@liggitt liggitt deleted the liggitt:bump-jsonpatch branch May 29, 2018

k8s-github-robot pushed a commit that referenced this pull request Jun 15, 2018

Kubernetes Submit Queue
Merge pull request #64446 from liggitt/automated-cherry-pick-of-#6435…
…5-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #64355: bump(github.com/evanphx/json-patch):

Cherry pick of #64355 on release-1.10.

#64355: bump(github.com/evanphx/json-patch):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.