Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #64150 upstream release 1.9 #64397

Conversation

wojtek-t
Copy link
Member

Cherry pick of #64150 on release-1.9.
#64150 : Fix incorrectly set resource version in List

@wojtek-t wojtek-t added this to the v1.9 milestone May 28, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 28, 2018
@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. milestone/incomplete-labels labels May 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2018
@wojtek-t wojtek-t added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 28, 2018
@wojtek-t
Copy link
Member Author

/retest

@liggitt
Copy link
Member

liggitt commented May 29, 2018

test compile error:

W0529 10:12:01.821] 2018/05/29 10:12:01 error running compiler: exit status 1
I0529 10:12:01.928] staging/src/k8s.io/apiserver/pkg/storage/tests/cacher_test.go:173:12: cannot assign 1 values to 2 variables
W0529 10:12:02.549] INFO: Elapsed time: 1551.596s, Critical Path: 238.77s
W0529 10:12:02.573] FAILED: Build did NOT complete successfully

LGTM other than that

@wojtek-t wojtek-t force-pushed the automated-cherry-pick-of-#64150-upstream-release-1.9 branch from 6ae0bdc to e4b0f93 Compare May 30, 2018 07:50
@wojtek-t
Copy link
Member Author

Fixed compile error in test. Applying label based on comment above.

@wojtek-t wojtek-t added lgtm "Looks good to me", indicates that a PR is ready to be merged. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. status/approved-for-milestone labels May 30, 2018
@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels May 30, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 30, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@jpbetz @liggitt @wojtek-t

Action required: This pull request requires label changes. If the required changes are not made within 1 day, the pull request will be moved out of the v1.9 milestone.

sig owner: Must specify at least one label prefixed with sig/.

Help

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 30, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit f8ed45a into kubernetes:release-1.9 May 31, 2018
@wojtek-t wojtek-t deleted the automated-cherry-pick-of-#64150-upstream-release-1.9 branch July 2, 2018 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants