Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PV GET api rule to external-provisioner #65070

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Added PV GET api rule to external-provisioner #65070

merged 1 commit into from
Jun 14, 2018

Conversation

davidz627
Copy link
Contributor

Adds the PV GET API rule to the system:external-provisioner cluster role. It is required because the provisioner does a GET here:
https://github.com/kubernetes-incubator/external-storage/blob/master/lib/controller/controller.go#L1121

Fixes #65058

/sig storage
/kind bug
/priority critical-urgent
/cc @msau42 @sbezverk

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 13, 2018
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 13, 2018
@davidz627
Copy link
Contributor Author

/assign @liggitt
for approval

@davidz627
Copy link
Contributor Author

Should also be cherrypicked to 1.11

@msau42
Copy link
Member

msau42 commented Jun 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2018
@liggitt
Copy link
Member

liggitt commented Jun 13, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, liggitt, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2018
This was referenced Jun 13, 2018
Closed
Merged
@jberkus
Copy link

jberkus commented Jun 13, 2018

assigning this to the 1.11 milestone so that it has some hope of merging. However, you need to get a lead from sig-storage to approve-for-milestone, because they need to support this.

/milestone v1.11

@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jun 13, 2018
@davidz627
Copy link
Contributor Author

davidz627 commented Jun 13, 2018 •
edited
Loading

/assign @saad-ali
for approve-for-milestone

@dims
Copy link
Member

dims commented Jun 14, 2018

/status approved-for-milestone

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@davidz627 @liggitt @msau42 @saad-ali

Pull Request Labels
  • sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@dims
Copy link
Member

dims commented Jun 14, 2018

We need this since external cloud providers to work properly!

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit eac9c4f into kubernetes:master Jun 14, 2018
@davidz627 davidz627 deleted the fix/externalProvisionerClusterRole branch June 14, 2018 17:54
@AishSundar
Copy link
Contributor

xref ##65129

All downgrade-cluster-parallel tests seem to be breaking post this change

@AishSundar AishSundar mentioned this pull request Jun 15, 2018
Closed
@liggitt
Copy link
Member

liggitt commented Jun 15, 2018

All downgrade-cluster-parallel tests seem to be breaking post this change

no, there was one green job after this merged. at first glance, the break seems more related to a test-infra change - kubernetes/test-infra#8358

k8s-github-robot pushed a commit that referenced this pull request Jun 15, 2018
Merge pull request #65073 from davidz627/fix/csiClusterRoles
75bf5cd 
Automatic merge from submit-queue.

Add RBAC policy rules for csi-external-provisioner and csi-external-attacher

Adds RBAC Policy rules for `csi-external-provisioner` and `csi-external-attacher` so that CSI drivers can bind to these cluster roles on every version of k8s where CSI is Beta or above.

These roles were added in 1.11 but never cherrypicked back to 1.10. The roles originally added as a part of a larger change here: #61866

 I could not do a direct cherry-pick because some of the RBAC primitives changed and there was also a fix applied on top with this PR:
#65070
The fix has been included in this commit. 

/kind enhancement
/sig storage
/cc @msau42 
/assign @liggitt @MaciekPytel

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@sbezverk sbezverk Awaiting requested review from sbezverk

Assignees

@liggitt liggitt

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@davidz627 @msau42 @liggitt @k8s-ci-robot @jberkus @dims @k8s-github-robot @AishSundar @saad-ali