-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RBAC policy rules for csi-external-provisioner and csi-external-attacher #65073
Add RBAC policy rules for csi-external-provisioner and csi-external-attacher #65073
Conversation
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627, liggitt, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@davidz627 Can you add a release note? There is some user visible change, so it's good if it shows up in notes for 1.10.5. |
[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete @MaciekPytel @davidz627 @liggitt @msau42 Action required: This pull request requires label changes. kind: Must specify exactly one of |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Adds RBAC Policy rules for
csi-external-provisioner
andcsi-external-attacher
so that CSI drivers can bind to these cluster roles on every version of k8s where CSI is Beta or above.These roles were added in 1.11 but never cherrypicked back to 1.10. The roles originally added as a part of a larger change here: #61866
I could not do a direct cherry-pick because some of the RBAC primitives changed and there was also a fix applied on top with this PR:
#65070
The fix has been included in this commit.
/kind enhancement
/sig storage
/cc @msau42
/assign @liggitt @MaciekPytel