New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document /watch prefix deprecation #65147

Merged
merged 1 commit into from Aug 7, 2018

Conversation

@liggitt
Member

liggitt commented Jun 15, 2018

closes #65133

these have been marked as deprecated in code for many releases, and all client accesses have switched to using the ?watch=true access method, but documentation was never updated

@kubernetes/sig-api-machinery-api-reviews @kubernetes/api-reviewers

The watch API endpoints prefixed with `/watch` are deprecated and will be removed in a future release. These standard method for watching resources (supported since v1.0) is to use the list API endpoints with a `?watch=true` parameter. All client-go clients have used the parameter method since v1.6.0.
@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Jun 15, 2018

Member

The /proxy prefix paths (deprecated since 1.2) were removed in 1.10 in #59884

I'd like to get deprecation of the /watch prefix paths on the record for 1.11.

Member

liggitt commented Jun 15, 2018

The /proxy prefix paths (deprecated since 1.2) were removed in 1.10 in #59884

I'd like to get deprecation of the /watch prefix paths on the record for 1.11.

@@ -382,7 +382,7 @@ func (a *APIInstaller) registerResourceHandlers(path string, storage rest.Storag
actions = appendIf(actions, action{"LIST", resourcePath, resourceParams, namer, false}, isLister)
actions = appendIf(actions, action{"POST", resourcePath, resourceParams, namer, false}, isCreater)
actions = appendIf(actions, action{"DELETECOLLECTION", resourcePath, resourceParams, namer, false}, isCollectionDeleter)
// DEPRECATED

This comment has been minimized.

@hzxuzhonghu

hzxuzhonghu Jun 20, 2018

Member

Haven't been deprecated long ago? Can we remove now?

@hzxuzhonghu

hzxuzhonghu Jun 20, 2018

Member

Haven't been deprecated long ago? Can we remove now?

This comment has been minimized.

@liggitt

liggitt Jun 20, 2018

Member

it wasn't formally announced, so not yet.

@liggitt

liggitt Jun 20, 2018

Member

it wasn't formally announced, so not yet.

This comment has been minimized.

@hzxuzhonghu
@hzxuzhonghu
@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Jun 21, 2018

Member

I was just saying on a api coverage spreadsheet that all these should be just deleted at this point...

cc @mbohlool to double check the open api spec

Member

lavalamp commented Jun 21, 2018

I was just saying on a api coverage spreadsheet that all these should be just deleted at this point...

cc @mbohlool to double check the open api spec

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Jun 21, 2018

Member

I was just saying on a api coverage spreadsheet that all these should be just deleted at this point...

cc @mbohlool to double check the open api spec

unfortunately, the endpoints are listed throughout the openapi spec, with no doc-visible deprecation notices. this PR updates it to note the deprecation - https://github.com/kubernetes/kubernetes/pull/65147/files#diff-9ce7ea8441086bf1902b4f936f4601d0

Member

liggitt commented Jun 21, 2018

I was just saying on a api coverage spreadsheet that all these should be just deleted at this point...

cc @mbohlool to double check the open api spec

unfortunately, the endpoints are listed throughout the openapi spec, with no doc-visible deprecation notices. this PR updates it to note the deprecation - https://github.com/kubernetes/kubernetes/pull/65147/files#diff-9ce7ea8441086bf1902b4f936f4601d0

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Jun 25, 2018

Member

@lavalamp @deads2k should we include this deprecation announcement in the 1.11 release notes?

Member

liggitt commented Jun 25, 2018

@lavalamp @deads2k should we include this deprecation announcement in the 1.11 release notes?

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt
Member

liggitt commented Jul 13, 2018

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Aug 1, 2018

Member

@liggitt needs-rebase (also, I'm happy to lgtm after rebase unless you specifically need approval from the aformentioned reviewers)

Member

spiffxp commented Aug 1, 2018

@liggitt needs-rebase (also, I'm happy to lgtm after rebase unless you specifically need approval from the aformentioned reviewers)

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Aug 6, 2018

Member

rebased. would like an ack from @lavalamp / @deads2k

Member

liggitt commented Aug 6, 2018

rebased. would like an ack from @lavalamp / @deads2k

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Aug 6, 2018

Member

/lgtm
/approve

Member

lavalamp commented Aug 6, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 6, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Aug 6, 2018

Member
/go/src/k8s.io/kubernetes/api/openapi-spec is out of date. Please run hack/update-openapi-spec.sh
/go/src/k8s.io/kubernetes/api/swagger-spec is out of date. Please run hack/update-swagger-spec.sh
Member

spiffxp commented Aug 6, 2018

/go/src/k8s.io/kubernetes/api/openapi-spec is out of date. Please run hack/update-openapi-spec.sh
/go/src/k8s.io/kubernetes/api/swagger-spec is out of date. Please run hack/update-swagger-spec.sh
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 7, 2018

Contributor

New changes are detected. LGTM label has been removed.

Contributor

k8s-ci-robot commented Aug 7, 2018

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 7, 2018

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Aug 7, 2018

Member

regenerated, retagging

Member

liggitt commented Aug 7, 2018

regenerated, retagging

@liggitt liggitt added the lgtm label Aug 7, 2018

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Aug 7, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Aug 7, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Aug 7, 2018

Member
/go/src/k8s.io/kubernetes/docs/api-reference is out of date. Please run hack/update-api-reference-docs.sh

... sure would have been nice if it said this last time

Member

spiffxp commented Aug 7, 2018

/go/src/k8s.io/kubernetes/docs/api-reference is out of date. Please run hack/update-api-reference-docs.sh

... sure would have been nice if it said this last time

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Aug 7, 2018

Member

/lgtm cancel
to stop fejta-bot from /retest spamming

Member

spiffxp commented Aug 7, 2018

/lgtm cancel
to stop fejta-bot from /retest spamming

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Aug 7, 2018

Member

third time's the charm

Member

liggitt commented Aug 7, 2018

third time's the charm

@liggitt liggitt added the lgtm label Aug 7, 2018

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 7, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Aug 7, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 7, 2018

Contributor

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 7, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 6bea053 into kubernetes:master Aug 7, 2018

17 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@liggitt liggitt deleted the liggitt:watch-prefix-deprecation branch Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment