Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus scrape port to CoreDNS service #65589

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Add prometheus scrape port to CoreDNS service #65589

merged 1 commit into from
Jun 29, 2018

Conversation

rajansandeep
Copy link
Contributor

@rajansandeep rajansandeep commented Jun 28, 2018 •
edited by luxas
Loading

What this PR does / why we need it:
Add prometheus scrape port

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #kubernetes/kubeadm#955

Special notes for your reviewer:

Release note:

Add prometheus scrape port to CoreDNS service

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2018
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jun 28, 2018
MrHohn
MrHohn approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2018
@neolit123
Copy link
Member

thanks @rajansandeep 👍

@neolit123
Copy link
Member

/test pull-kubernetes-e2e-gce

@neolit123
Copy link
Member

FYI, i'm pretty sure we want this fix for 1.11.1.

@rajansandeep
Copy link
Contributor Author

Is there any process for that?
Or this automatically gets picked.

@neolit123
Copy link
Member

it needs special labels from sig maintainers:
cherrypick-candidate
priority/critical-urgent
status/approved-for-milestone

luxas
luxas approved these changes Jun 29, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!

@luxas luxas added sig/network Categorizes an issue or PR as relevant to SIG Network. cherrypick-candidate labels Jun 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, MrHohn, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2018
@luxas luxas added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 29, 2018
@luxas luxas added this to the v1.11 milestone Jun 29, 2018
@luxas luxas added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@MrHohn @rajansandeep

Pull Request Labels
  • sig/cluster-lifecycle sig/network: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 90f681b into kubernetes:master Jun 29, 2018
@luxas luxas mentioned this pull request Jun 29, 2018
Closed
9 tasks
@luxas
Copy link
Member

luxas commented Jun 29, 2018

@rajansandeep please cherrypick this against the release-1.11 branch

@rajansandeep rajansandeep mentioned this pull request Jun 29, 2018
Merged
@rajansandeep
Copy link
Contributor Author

@luxas done!
#65650

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 29, 2018
k8s-github-robot pushed a commit that referenced this pull request Jul 3, 2018
Merge pull request #65650 from rajansandeep/automated-cherry-pick-of-…
0e46d5e 
…#65589-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65589: add scrape port to service

Cherry pick of #65589 on release-1.11.

#65589: add scrape port to service
@mjtrangoni mjtrangoni mentioned this pull request Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

@MrHohn MrHohn MrHohn approved these changes

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rajansandeep @neolit123 @k8s-ci-robot @k8s-github-robot @luxas @MrHohn