Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick tracking issue for v1.11 #958

Closed
8 of 9 tasks
luxas opened this issue Jun 29, 2018 · 2 comments
Closed
8 of 9 tasks

Cherrypick tracking issue for v1.11 #958

luxas opened this issue Jun 29, 2018 · 2 comments
Assignees
Labels
area/releasing kind/tracking-issue priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@luxas
Copy link
Member

luxas commented Jun 29, 2018

This issue serves as an umbrella to track the kubeadm-related PRs we cherrypick into the v1.11 branch.

I propose that @timothysc function as the cherrypick lead on the kubeadm side

I've identified a list of PRs to be cherrypicked:

Individual cherrypick PRs should be created as documented here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md

TL;DR; download https://github.com/github/hub, make sure git remote -v looks something like this and execute:

$ git remote -v
origin	git@github.com:luxas/kubernetes.git (fetch)
origin	git@github.com:luxas/kubernetes.git (push)
upstream	https://github.com/kubernetes/kubernetes (fetch)
upstream	DISABLE (push)

# Example command
GITHUB_USER=luxas hack/cherry_pick_pull.sh upstream/release-1.11 12345

The script will do everything for you, including creating the PR. You only need to get approval from @timothysc / me as kubeadm approvers and @foxish that is the v1.11 patch manager and then the cherrypick can be merged!

@neolit123
Copy link
Member

i think we should keep this one open until we no longer track 1.11 cherry picks?
feel free to override my /reopen.

@neolit123 neolit123 reopened this Aug 8, 2018
@neolit123
Copy link
Member

closed as per slack discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/releasing kind/tracking-issue priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants