Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #64427: add external resource group support for azure disk #65689

Merged
merged 5 commits into from Aug 10, 2018
Merged

Automated cherry pick of #64427: add external resource group support for azure disk #65689

merged 5 commits into from Aug 10, 2018

Conversation

andyzhangx
Copy link
Member

Cherry pick of #64427 on release-1.9.

#64427: add external resource group support for azure disk

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 2, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 2, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2018
@andyzhangx
Copy link
Member Author

andyzhangx commented Jul 2, 2018 •
edited

/assign @jsafrane @rootfs
This is a combined cherry-pick with #64427, #65443, #65516,
#65691

@andyzhangx
Copy link
Member Author

@jsafrane I have cherry-picked with #65691 now, PTAL

@jsafrane
Copy link
Member

jsafrane commented Jul 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2018
@nikhita
Copy link
Member

nikhita commented Jul 6, 2018

/assign @colemickens
for approval

/assign @mbohlool
for cherry-pick approval

@andyzhangx
Copy link
Member Author

/assign @feiskyer for approval

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @feiskyer for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

@brendandburns for approval

@feiskyer
Copy link
Member

feiskyer commented Jul 6, 2018

/lgtm
/approve

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@nikhita
Copy link
Member

nikhita commented Jul 18, 2018

/retest

@feiskyer
Copy link
Member

ping @colemickens for approval

@nikhita
Copy link
Member

nikhita commented Jul 18, 2018 via email

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 24, 2018
@mbohlool
Copy link
Contributor

/retest

@mbohlool
Copy link
Contributor

/hold

1.9 branch is frozen for the release.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2018
@andyzhangx
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2018
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-kops-aws

@brendandburns
Copy link
Contributor

/retest
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, brendandburns, feiskyer, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2018
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit a2c6e6d into kubernetes:release-1.9 Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@msau42 msau42 Awaiting requested review from msau42

Assignees

@colemickens colemickens

@feiskyer feiskyer

@mbohlool mbohlool

@jsafrane jsafrane

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@andyzhangx @jsafrane @nikhita @k8s-ci-robot @feiskyer @mbohlool @brendandburns @k8s-github-robot @colemickens @rootfs