Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go1.10.3 #65726

Merged
merged 1 commit into from Jul 3, 2018

Conversation

@ixdy
Copy link
Member

ixdy commented Jul 2, 2018

What this PR does / why we need it: updates to build with go1.10.3; see list of changes here.

We'll probably want to cherrypick this to release-1.11 as well.

Release note:

Update to use go1.10.3

/assign @BenTheElder @cblecker

@ixdy

This comment has been minimized.

Copy link
Member Author

ixdy commented Jul 2, 2018

/release-note

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 2, 2018

@ixdy: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -336,7 +336,7 @@ EOF
local go_version
IFS=" " read -ra go_version <<< "$(go version)"
local minimum_go_version
minimum_go_version=go1.10.2
minimum_go_version=go1.10.3

This comment has been minimized.

@cblecker

cblecker Jul 2, 2018

Member

Do we need to bump the minimum here?

This comment has been minimized.

@ixdy

ixdy Jul 2, 2018

Author Member

I guess not. I can revert this, since it'll make CI easier to update.

@ixdy ixdy force-pushed the ixdy:golang-1.10.3 branch from 725bcd6 to 0333b8a Jul 2, 2018

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Jul 2, 2018

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jul 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 3, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 3, 2018

Automatic merge from submit-queue (batch tested with PRs 65677, 65711, 65150, 65726). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f29c130 into kubernetes:master Jul 3, 2018

17 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation ixdy authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@warmchang

This comment has been minimized.

Copy link
Contributor

warmchang commented Jul 6, 2018

Hi, may I ask what is the policy to update the Go lang compiler? Keep following the latest version?

@ixdy

This comment has been minimized.

Copy link
Member Author

ixdy commented Jul 6, 2018

@warmchang we generally try to keep up to date with the latest patch release (for example, 1.10.2 -> 1.10.3 here) for the relevant bug fixes.

We update to the latest minor release (for example, 1.9 -> 1.10) less aggressively, since there are often bugs or other issues to be worked out first, and we want to ensure enough time to soak test the new release, so we don't update close to the kubernetes release date.

This is why kubernetes 1.11 is the first release to use go1.10: while go1.10 was released prior to kubernetes 1.10 being released, it was too close to our cut.

@warmchang

This comment has been minimized.

Copy link
Contributor

warmchang commented Jul 7, 2018

Got it, thank you @ixdy !

k8s-github-robot pushed a commit that referenced this pull request Jul 12, 2018

Kubernetes Submit Queue
Merge pull request #65984 from ixdy/automated-cherry-pick-of-#65726-u…
…pstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65726: Update to go1.10.3

Cherry pick of #65726 on release-1.11.

#65726: Update to go1.10.3
@marpaia

This comment has been minimized.

Copy link
Member

marpaia commented Jul 25, 2018

/sig release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.