Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #65702: Reload systemd config files before starting kubelet. #65748

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Automated cherry pick of #65702: Reload systemd config files before starting kubelet. #65748

merged 1 commit into from
Jul 4, 2018

Conversation

mborsz
Copy link
Member

@mborsz mborsz commented Jul 3, 2018

Cherry pick of #65702 on release-1.10.

#65702: Reload systemd config files before starting kubelet.

@mborsz
Reload systemd config files before starting kubelet.
fb121ff 
In some environments, the os image comes with preloaded kubelet.service,
so we need to reload systemctl configs to make changes effective.
@k8s-ci-robot
Copy link
Contributor

@mborsz: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #65702.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@mborsz: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 3, 2018
@k8s-ci-robot k8s-ci-robot requested review from gmarek and vishh July 3, 2018 07:39
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 3, 2018
@mborsz
Copy link
Member Author

mborsz commented Jul 3, 2018

/assign @wojtek-t

@wojtek-t
Copy link
Member

wojtek-t commented Jul 3, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2018
@wojtek-t wojtek-t added this to the v1.10 milestone Jul 3, 2018
@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 3, 2018
@MaciekPytel
Copy link
Contributor

@mborsz Can you add release note to #65702?

@mborsz
Copy link
Member Author

mborsz commented Jul 3, 2018

I added release note to the PR description in #65702, but I don't know how to populate that change here.

Any suggestion?

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@MaciekPytel @mborsz @wojtek-t

Action required: This pull request requires label changes. If the required changes are not made within 2 days, the pull request will be moved out of the v1.10 milestone.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.
sig owner: Must specify at least one label prefixed with sig/.

Help

@MaciekPytel MaciekPytel added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 4, 2018
@MaciekPytel
Copy link
Contributor

@mborsz Thanks. The release note will be picked up by release tooling. I fixed the label manually and this should be good to go.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit f959dfb into kubernetes:release-1.10 Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek Awaiting requested review from gmarek

@vishh vishh Awaiting requested review from vishh

Assignees

@MaciekPytel MaciekPytel

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mborsz @k8s-ci-robot @wojtek-t @MaciekPytel @k8s-github-robot