Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-scheduler: allow high ports in secure serving validation #65833

Merged
merged 1 commit into from Jul 5, 2018

Conversation

@sttts
Copy link
Contributor

sttts commented Jul 4, 2018

Certain operating systems will select high port (>32768) when asked for a free port. This PR changes the validation to allow that.

Allow kube-scheduler to listen on ports up to 65535.
@sttts

This comment has been minimized.

Copy link
Contributor Author

sttts commented Jul 4, 2018

/approve

@hzxuzhonghu

This comment has been minimized.

Copy link
Member

hzxuzhonghu commented Jul 5, 2018

/lgtm

Not only scheduler, kube-apiserver and controller-manager both have the same issue.

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 5, 2018

@sttts

This comment has been minimized.

Copy link
Contributor Author

sttts commented Jul 5, 2018

/assign @wojtek-t

for approval.

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Jul 5, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, sttts, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts sttts changed the title apiserver: allow high ports in secure serving validation kube-scheduler: allow high ports in secure serving validation Jul 5, 2018

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 5, 2018

Automatic merge from submit-queue (batch tested with PRs 65805, 65811, 65833, 65488, 65857). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 2fa1a2e into kubernetes:master Jul 5, 2018

17 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation sttts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request Jul 6, 2018

Kubernetes Submit Queue
Merge pull request #65860 from sttts/sttts-high-ports
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

controller-managers: allow high ports in secure serving validation

Certain operating systems will select high port (>32768) when asked for a free port. This PR changes the validation to allow that.

Like #65833, but for controller managers.

```release-note
Allow kube- and cloud-controller-manager to listen on ports up to 65535.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.