Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded deps #65946

Merged
merged 1 commit into from
Jul 7, 2018
Merged

Remove unneeded deps #65946

merged 1 commit into from
Jul 7, 2018

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Jul 7, 2018

What this PR does / why we need it:
#65707 removed reliance on github.com/google/cadvisor/http (and it's dependencies), but we forgot to clean up the dep. This is causing failures in batches and postsubmits.

Release note:

NONE

/cc @BenTheElder @dims @dashpole @luxas @philips @yujuhong

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2018
BenTheElder
BenTheElder approved these changes Jul 7, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2018
dims
dims approved these changes Jul 7, 2018
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Jul 7, 2018

Thanks @cblecker

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 60c44af into kubernetes:master Jul 7, 2018
@cblecker cblecker deleted the fix-godeps-65707 branch July 7, 2018 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

@BenTheElder BenTheElder BenTheElder approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@luxas luxas Awaiting requested review from luxas

@philips philips Awaiting requested review from philips

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@dims dims

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cblecker @k8s-ci-robot @dims @k8s-github-robot @BenTheElder