Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --cadvisor-port - has been deprecated since v1.10 #65707

Merged
merged 1 commit into from
Jul 7, 2018
Merged

Remove --cadvisor-port - has been deprecated since v1.10 #65707

merged 1 commit into from
Jul 7, 2018

Conversation

dims
Copy link
Member

@dims dims commented Jul 2, 2018 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #56523

Special notes for your reviewer:

Release note:

[action required] The formerly publicly-available cAdvisor web UI that the kubelet started using `--cadvisor-port` is now entirely removed in 1.12. The recommended way to run cAdvisor if you still need it, is via a DaemonSet.

@dims
Remove --cadvisor-port - has been deprecated since v1.10
5feab86 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 2, 2018
@dims
Copy link
Member Author

dims commented Jul 2, 2018

/assign @luxas

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2018
luxas
luxas reviewed Jul 2, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @mtaufen @dashpole @derekwaynecarr
for approval
Thanks @dims!

@dashpole
Copy link
Contributor

dashpole commented Jul 2, 2018

/lgtm

@philips
Copy link
Contributor

philips commented Jul 2, 2018

/lgtm

so happy this is happening.

feiskyer
feiskyer reviewed Jul 3, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims
Copy link
Member Author

dims commented Jul 5, 2018

/assign @Random-Liu
/assign @yujuhong

@yujuhong
Copy link
Contributor

yujuhong commented Jul 6, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dims, luxas, philips, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2018
@dims
Copy link
Member Author

dims commented Jul 6, 2018

/test pull-kubernetes-local-e2e-containerized

@BenTheElder
Copy link
Member

super minor but:

[action required] The formerly publicly-available cAdvisor web UI that the kubelet started using --cadvisor-port is now entiely removed in 1.12. The recommended way to run cAdvisor if you still need it, is via a DaemonSet.

s/entiely/entirely/ in the release-note

@dims
Copy link
Member Author

dims commented Jul 6, 2018

/test pull-kubernetes-local-e2e-containerized

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 097f300 into kubernetes:master Jul 7, 2018
@cblecker cblecker mentioned this pull request Jul 7, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 7, 2018
Merge pull request #65946 from cblecker/fix-godeps-65707
60c44af 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove unneeded deps

**What this PR does / why we need it**:
#65707 removed reliance on `github.com/google/cadvisor/http` (and it's dependencies), but we forgot to clean up the dep. This is causing failures in batches and postsubmits.

**Release note**:
```release-note
NONE
```

/cc @BenTheElder @dims @dashpole @luxas @philips @yujuhong
@sjenning sjenning mentioned this pull request Aug 1, 2018
Closed
@tallclair tallclair added this to the v1.12 milestone Aug 1, 2018
@tallclair
Copy link
Member

It turns out #63881 didn't actually make it into 1.11.

Should we consider rolling-back this PR so that there is 1 release with cAdvisor disabled by default but still available? (And re-merging this in 1.13?)

@luxas
Copy link
Member

luxas commented Aug 2, 2018

It turns out #63881 didn't actually make it into 1.11.

I'm not sure that is actually true?

@dims
Copy link
Member Author

dims commented Aug 2, 2018 •
edited

I can see v1.11.0 in both commits SHA's (from 63881)

f4d0708
703dc82

@tallclair
Copy link
Member

Sorry, disregard my comment. Not sure what happened.

@dims dims mentioned this pull request Aug 21, 2018
Merged
This was referenced Nov 30, 2018
Merged
Merged
@WanLinghao WanLinghao mentioned this pull request Jan 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@luxas luxas luxas left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@philips philips

@mtaufen mtaufen

@dashpole dashpole

@luxas luxas

@Random-Liu Random-Liu

@derekwaynecarr derekwaynecarr

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

Deprecate Kubelet cAdvisor port