Automated cherry pick of #65931: kubeadm: run kube-proxy on non-master tainted nodes #66043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kube-proxy should be able to run on all nodes, independent on the taint of such nodes. This restriction was previously removed in bb28449 but then was brought back in d194926. Also, annotate with: scheduler.alpha.kubernetes.io/critical-pod: "" and add a class in the template spec: priorityClassName: system-node-critical
k8s-ci-robot
added
size/S
k8s-github-robot
added
the
do-not-merge/cherry-pick-not-approved
9 tasks
|
@timothysc @foxish our "cherry-tracking" list: |
foxish
added
cherry-pick-approved
|
@neolit123, can someone else eyeball this change and LGTM? |
|
nvm, saw that the pull is identical to the one that landed in master. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxish, luxas, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
neolit123
deleted the
automated-cherry-pick-of-#65931-origin-release-1.11
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #65931 on release-1.11.
#65931: kubeadm: run kube-proxy on non-master tainted nodes