Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make delete waits match on UID #66136

Merged
merged 1 commit into from Jul 12, 2018

Conversation

@deads2k
Copy link
Contributor

deads2k commented Jul 12, 2018

If you delete an object, there is a race where something can recreate it with a different UID and the wait will wait forever. This allows passing a UID through

@kubernetes/sig-cli-maintainers
@soltysh @liggitt

prevents infinite CLI wait on delete when item is recreated

@deads2k deads2k force-pushed the deads2k:cli-02-delete-uid branch from 5881e42 to 9fe20cf Jul 12, 2018

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jul 12, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added this to the v1.11 milestone Jul 12, 2018

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jul 12, 2018

/sig cli
/kind bug
/priority important-soon
/status approved-for-milestone

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 12, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@deads2k @liggitt

Pull Request Labels
  • sig/cli: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 12, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@juanvallejo

This comment has been minimized.

Copy link
Member

juanvallejo commented Jul 12, 2018

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 12, 2018

Automatic merge from submit-queue (batch tested with PRs 66136, 64999, 65425, 66120, 66074). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 10007ec into kubernetes:master Jul 12, 2018

15 of 17 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-kops-aws
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request Jul 19, 2018

Kubernetes Submit Queue
Merge pull request #66164 from liggitt/automated-cherry-pick-of-#65370-
…#66136-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65370: delete should tolerate a failed wait because of missing verbs

#66136: make delete waits match on UID

Cherry pick of #65370 #66136 on release-1.11.

#65370: delete should tolerate a failed wait because of missing verbs
#66136: make delete waits match on UID

```release-note
fixes `kubectl delete` failures when the resource being deleted doesn't support get/watch, or when the resource is rapidly recreated with the same name
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.