Remove the Heapster/InfluxDB test #66175
Conversation
Heapster is now deprecated, and we shouldn't be testing Influx functionality here anyway (that test belongs in the Heapster repo at best anyway).
k8s-ci-robot
added
size/L
|
cc @kubernetes/sig-instrumentation-pr-reviews |
k8s-ci-robot
added
the
sig/instrumentation
|
But this is not going to be cherry-picked in 1.11, isn't it? |
|
@loburm I wasn't initially planning on it, why? |
|
Just wanted to ensure that those tests are not going to be removed from 1.11 testing pipeline. |
k8s-ci-robot
added
the
lgtm
|
cc @kubernetes/sig-testing-pr-reviews @saad-ali for the line removal from test-owners |
k8s-ci-robot
added
the
sig/testing
|
/approve x-ref #62328 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, ixdy, loburm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
/test all Tests are more than 96 hours old. Re-running tests. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@DirectXMan12: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 66175, 66324, 65828, 65901, 66350). If you want to cherry-pick this change to another branch, please follow the instructions here. |
|
@DirectXMan12 I'm wondering if this commit is related to a new test failure in https://k8s-testgrid.appspot.com/sig-release-master-blocking#verify: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-verify-master/22119 |
|
@tpepper yeah, I've got a patch coming along. Forgot to remove stuff from godeps after it was no longer needed. |
Automatic merge from submit-queue (batch tested with PRs 66410, 66398, 66061, 66397, 65558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update Godeps after removing influx tests When the influx tests were removed, it should have also removed the influx deps from Godeps. This does that. See also #66175 **Release note**: ```release-note NONE ```
|
@DirectXMan12 Looks like you didn't clean up the test suite https://k8s-testgrid.appspot.com/sig-instrumentation#gce-influxdb |
Heapster is now deprecated, and we shouldn't be testing Influx
functionality here anyway (that test belongs in the Heapster repo at
best anyway).
Release note: