New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote ShareProcessNamespace to beta #66507

Merged
merged 3 commits into from Aug 9, 2018

Conversation

@verb
Contributor

verb commented Jul 23, 2018

What this PR does / why we need it: The ability to configure PID namespace sharing per-pod was added as an alpha feature in 1.10. This promotes the feature to beta and makes the feature available by default.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
WIP #1615

Special notes for your reviewer:
/assign @yujuhong

Release note:

The PodShareProcessNamespace feature to configure PID namespace sharing within a pod has been promoted to beta.
@verb

This comment has been minimized.

Contributor

verb commented Jul 23, 2018

/retest

@yujuhong

This comment has been minimized.

Contributor

yujuhong commented Jul 23, 2018

@yujuhong

This comment has been minimized.

Contributor

yujuhong commented Jul 23, 2018

/assign @dchen1107

@yujuhong

This comment has been minimized.

Contributor

yujuhong commented Jul 23, 2018

@verb the code should be removed in DropDisabledAlphaFields as well.

@yujuhong yujuhong removed the lgtm label Jul 23, 2018

@yujuhong

This comment has been minimized.

Contributor

yujuhong commented Jul 23, 2018

Otherwise, lgtm.

Retain ShareProcessNamespace in pod storage
This field is no longer alpha, so don't drop it with the other alpha fields.

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Jul 24, 2018

@verb

This comment has been minimized.

Contributor

verb commented Jul 24, 2018

@yujuhong sure thing. I removed the code from DropDisabledAlphaFields and left the check in validation.

@verb

This comment has been minimized.

Contributor

verb commented Jul 24, 2018

/retest

@yastij

yastij approved these changes Jul 24, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 24, 2018

@yastij

This comment has been minimized.

Member

yastij commented Jul 24, 2018

/hold

Can @kubernetes/api-approvers take a look as we are moving sharedPID to beta ?

@yujuhong

This comment has been minimized.

Contributor

yujuhong commented Jul 25, 2018

/lgtm

@tallclair

This comment has been minimized.

Member

tallclair commented Jul 25, 2018

This promotes the feature to beta and enables it by default.

To clarify, this enables the feature to be used by default, it doesn't actually default ShareProcessNamespace to true. Right?

@verb

This comment has been minimized.

Contributor

verb commented Jul 25, 2018

@tallclair Correct. The pod default is unchanged. If ShareProcessNamespace is not specified in pod config, isolated process namespaces are still used. This PR makes the feature available unless disabled with --feature-gate=PodShareProcessNamespace=false.

Sorry for the confusing wording, I will update the description.

@verb

This comment has been minimized.

Contributor

verb commented Aug 8, 2018

/retest

@verb

This comment has been minimized.

Contributor

verb commented Aug 8, 2018

@liggitt @smarterclayton commented on this in alpha. Can one of you review this for beta?

@yujuhong

This comment has been minimized.

Contributor

yujuhong commented Aug 8, 2018

/assign @liggitt
/assign @smarterclayton

@dchen1107

This comment has been minimized.

Member

dchen1107 commented Aug 8, 2018

/lgtm

@dchen1107

This comment has been minimized.

Member

dchen1107 commented Aug 8, 2018

/retest

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Aug 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, verb, yastij, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Member

liggitt commented Aug 8, 2018

@liggitt @smarterclayton commented on this in alpha. Can one of you review this for beta?

I don't have any objections, but don't have a good sense for what feedback we got on this. Will defer to sig-node

@verb

This comment has been minimized.

Contributor

verb commented Aug 9, 2018

@liggitt deferred to sig-node for api-approvers. Since @dchen1107 gave approval for sig-node I'll go ahead and remove the hold.

/hold cancel

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Aug 9, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Aug 9, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 8ebc84e into kubernetes:master Aug 9, 2018

17 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation verb authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment